orbea

Results 339 comments of orbea

> My attention has been elsewhere, since in my eyes, this project has been complete for a while. I would greatly appreciate if dyndeps could be added at some point...

For building cpp-httplib itself it is enough to add `-DSSL_get1_peer_certificate=SSL_get_peer_certificate` to the CXXFLAGS, but the tests also fail. ``` * abi_x86_64.amd64: running multilib-minimal_abi_src_test make LIBTOOL=rlibtool -j4 -C test CXX=x86_64-pc-linux-musl-g++ 'CXXFLAGS=-O2...

This patch is enough to build httplib-cpp, but if possible it would be nice to have this working more out of the box in the future. ``` --- a/CMakeLists.txt +++...

I should of checked more recent versions than the version marked as stable by Gentoo, with `0.16.2` also fails because `OPENSSL_thread_stop` is missing. Gentoo doesn't yet have any of the...

I could not find how they avoid the version check for BoringSSL even if they have checks for it in httplib.h where they also disable `OPENSSL_thread_stop`. https://github.com/yhirose/cpp-httplib/blob/80fb03628bb57ca9d3ab855a7feec2876249bb61/httplib.h#L779-L781 Also I am...

This patch works for `0.16.3`. ``` --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -81,7 +81,7 @@ project(httplib # Change as needed to set an OpenSSL minimum version. # This is used in...

With the cpp-httplib git repo (https://github.com/yhirose/cpp-httplib/commit/80fb03628bb57ca9d3ab855a7feec2876249bb61) the tests do not fail, they just hang on an `openssl` command. ``` openssl genrsa 2048 > key.pem python3 ../split.py -o . Generating RSA...

Thanks, that patch allows the tests to run, a few fail. ``` [ FAILED ] 3 tests, listed below: [ FAILED ] ConnectionErrorTest.InvalidHost [ FAILED ] ConnectionErrorTest.InvalidHost2 [ FAILED ]...

@vgough I realize this project is not maintained, but I would really appreciate if you could review this relatively trivial PR.

@benkohler Can you please review this PR?