pktvisor icon indicating copy to clipboard operation
pktvisor copied to clipboard

Create Dns Xact Handler

Open leoparente opened this issue 3 years ago • 3 comments

  • Create Common Visor DNS Headers
  • Remove all transaction logic from DNS Handler
  • Create Own DNS Xact Handler
  • Some filters should only be performed if the packet is response (so transaction can still be tracked)

leoparente avatar Aug 05 '22 21:08 leoparente

Improvements questions: on DNS Xact Will Filter we should delete transaction that will be filtered out? I think So..

leoparente avatar Aug 05 '22 21:08 leoparente

This pull request introduces 1 alert when merging ff7745cf3311bff74bb00572bec5a2cd61ff29c7 into 531661337701ccbfaf52db7f6a5fa9927a82dffb - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter

lgtm-com[bot] avatar Aug 05 '22 23:08 lgtm-com[bot]

This pull request introduces 1 alert when merging 06d493a95e5e657bdb5e75f9ccb74e7ed1e70b99 into cc2b1c57408e339e8a4188bfc59970dafc1ce200 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter

lgtm-com[bot] avatar Aug 11 '22 22:08 lgtm-com[bot]

This pull request introduces 1 alert when merging 9aa103d8b897eb13a77c511decd1de129fb9febb into 30b6da28b5a3581df54b88109174514fcf267be5 - view on LGTM.com

new alerts:

  • 1 for Declaration hides parameter

lgtm-com[bot] avatar Aug 17 '22 18:08 lgtm-com[bot]

This is in Draft, is it ready for review?

weyrick avatar Aug 25 '22 13:08 weyrick

This is in Draft, is it ready for review?

No, It is not. Things changed a lot on DnsHandler, rebase this will be difficult. I will start over.

leoparente avatar Aug 25 '22 19:08 leoparente