rust-oci-client icon indicating copy to clipboard operation
rust-oci-client copied to clipboard

Allow doing start-end RANGE requests against blobs

Open thundergolfer opened this issue 1 year ago • 3 comments

Addresses https://github.com/oras-project/rust-oci-client/issues/162

thundergolfer avatar Sep 08 '24 16:09 thundergolfer

Oh damn sorry I thought this was compiling because I was pointing at my fork but I had a cached main 😖

thundergolfer avatar Sep 10 '24 15:09 thundergolfer

@flavio I updated the implementation and added a test. During reimplementation I switch to using pull_blob_stream_partial and ran into an issue where VerifyingStream doesn't work when you get a partial response back (the digests will never match).

I'm not sure how this was working before? Let me know what you think :)

thundergolfer avatar Sep 10 '24 19:09 thundergolfer

@thundergolfer thanks for having introduced the test case.

@thomastaylor312 can you take a quick look too?

flavio avatar Sep 23 '24 08:09 flavio

Nice, thanks. Let me know if you need anything else before merge 👌

thundergolfer avatar Oct 01 '24 02:10 thundergolfer

Sorry forgot to add context when I hit the submit button. This all looks good to me. One minor point around adding some clarification to the docs for a function around the security implications

thomastaylor312 avatar Oct 04 '24 17:10 thomastaylor312