oras
oras copied to clipboard
oras-project
Make `--identity-token` an alias of `--password`
What is the version of your ORAS CLI
v0.16.0
What would you like to be added?
Make --identity-token an alias of --password
Why is this needed for ORAS?
oras supports using identity token as the credential without a username.
The UX of oras login $REGISTRY --password $TOKEN does not seem good enough. It will be better if it is
oras login $REGISTRY --identity-token $TOKEN
Are you willing to submit PRs to contribute to this feature?
- [ ] Yes, I am willing to implement it.
What if a user mistakenly use oras login $REGISTRY --username $USERNAME --identity-token $TOKEN
What if a user mistakenly use
oras login $REGISTRY --username $USERNAME --identity-token $TOKEN
I think we should return error for this case.
Not all registry support token refreshing from identity token to registry token. E.g. ghcr returns 405 for token refreshing.
@shizhMSFT We should also add a flag --registry-token allow user to use registry token in oras commands.
Not all registry support token refreshing from identity token to registry token. E.g. ghcr returns 405 for token refreshing.
@shizhMSFT We should also add a flag
--registry-tokenallow user to use registry token in oras commands.
That can be another issue and I noticed that you have created one #968
Oh sorry for the delays. I was busy with some other stuff and left the task hanging. Will push it before Monday.
@shizhMSFT Do we also need
--registry-token-stdin?
SGTM but is that --identity-token-stdin?
@sbdtu5498 So we need to add another flag to enable read identity token from stdin like:
echo $TOKEN | oras login $REGISTRY --identity-token-stdin