oras icon indicating copy to clipboard operation
oras copied to clipboard

oras should be able to tag the same digest with different tags

Open milosgajdos opened this issue 2 years ago • 4 comments

We've been experimenting with oras for a bit while and came across a rather unexpected behaviour. Specifically, oras cli does not seem to be able to tag the same [manifest] digest with different tags.

Example scenario: I want to push some content to a registry and tag it with a tag. Then I want to tag the same content with a different tag. The latter does not happen. My suspicion is on the RE-tag, oras does HEAD request on manifest digest but not on the tag -- it finds the digest exists and never follows up with the new tag.

Is there any specific reason for this behaviour? I can't think of any.

How to reproduce this:

Push some content to a registry:

$ oras milosgajdos/foo:1.2.3 foo.txt:application/vnd.unknown.layer.v1+txt
Uploading 63c2b3576834 foo.txt
Pushed milosgajdos/foo:1.2.3
Digest: sha256:6f2ee3eaa3f6fc53ce908fa95fe3e0efa49687b37872e27ad88bba8fd74fe3c1

Push a new tag for the same content:

$ oras milosgajdos/foo:4.5.6 foo.txt:application/vnd.unknown.layer.v1+txt
Exists    6f2ee3eaa3f6
Pushed milosgajdos/foo:4.5.6
Digest: sha256:6f2ee3eaa3f6fc53ce908fa95fe3e0efa49687b37872e27ad88bba8fd74fe3c1

The worst thing is, the oras on re-TAG (i.e. push with different tag) prints output that seems to suggest that the new tag has been pushed:

Pushed milosgajdos/foo:4.5.6

But that doesn't seem to be the case.

milosgajdos avatar Aug 09 '22 10:08 milosgajdos

This issue should be opened on the ORAS CLI repo. /cc @qweeah @milosgajdos Which oras CLI version are you using?

Wwwsylvia avatar Aug 11 '22 03:08 Wwwsylvia

@milosgajdos This is a known issue (https://github.com/oras-project/oras/issues/447 and https://github.com/oras-project/oras-go/issues/239) for 0.13.0. It has been fixed in the main branch but we haven't released a new version(0.14.0) yet.

qweeah avatar Aug 11 '22 05:08 qweeah

Thanks for the heads up @qweeah . Can we keep this open until we verify 0.14.0 fixes the problem when it's released.

milosgajdos avatar Aug 12 '22 08:08 milosgajdos

@milosgajdos Could you verify whether this issue is fixed in ORAS CLI 0.14.0? Thanks.

yizha1 avatar Aug 31 '22 12:08 yizha1

This seems to be fixed. Thanks!

milosgajdos avatar Oct 21 '22 09:10 milosgajdos