oras
oras copied to clipboard
feat!: pass annotations as a string
Codecov Report
Merging #468 (c0ea7d6) into main (7c6fbdb) will increase coverage by
11.88%
. The diff coverage is81.25%
.
@@ Coverage Diff @@
## main #468 +/- ##
===========================================
+ Coverage 55.69% 67.58% +11.88%
===========================================
Files 6 7 +1
Lines 237 327 +90
===========================================
+ Hits 132 221 +89
+ Misses 90 85 -5
- Partials 15 21 +6
Impacted Files | Coverage Δ | |
---|---|---|
cmd/oras/internal/option/packer.go | 81.25% <81.25%> (ø) |
|
internal/cache/target.go | 72.46% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
We need unit tests. Let there be unit tests.
Going to update UX, as discussed with the community, exiting with error when both flags are provided is a good option for now. @shizhMSFT
/cc @sajayantony @qweeah
Going to update UX, as discussed with the community, exiting with error when both flags are provided is a good option for now. @shizhMSFT
cc. @sajayantony @qweeah
@junczhuMSFT This looks good. I think #466 can also apply this UX: if both manifest-config
and artifact-type
are specified for oras push
, then exit with error /cc @yuehaoliang-microsoft
@junczhuMSFT Since this changes the pusher
option, we should also update CLI help doc for oras push
and oras attach
@junczhuMSFT Since this changes the pusher option, we should also update CLI help doc for oras push and oras attach
Well Noted
We need unit tests. Let there be unit tests.
Working on it