oras-project
Missing verify argument in providers.py
On line 906 of https://github.com/oras-project/oras-py/blob/main/oras/provider.py, the argument verify=self._tls_verify, has been omitted. As a result, if you are using tls_verify=False in a dev environment and there is a non-tls related error connecting to the registry, you will only receive a tls error. Apologies if this is not the correct place to report this bug, I did not see an alternative in the contributing guidelines. I would make a PR myself, but I found this at work and cannot do so.
I can put in a quick PR for you to review / test for your environment, does that work?
Yeah I can do that!
On Fri, Nov 17, 2023, 11:27 AM Vanessasaurus @.***> wrote:
I can put in a quick PR for you to review / test for your environment, does that work?
— Reply to this email directly, view it on GitHub https://github.com/oras-project/oras-py/issues/117#issuecomment-1816897173, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBTO52TWTRIQRCSAGLSH23YE6UCXAVCNFSM6AAAAAA7QFV2DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHA4TOMJXGM . You are receiving this because you authored the thread.Message ID: @.***>
Looks like you also need line 922
On Fri, Nov 17, 2023 at 11:32 AM Ryan Schulman @.***> wrote:
Yeah I can do that!
On Fri, Nov 17, 2023, 11:27 AM Vanessasaurus @.***> wrote:
I can put in a quick PR for you to review / test for your environment, does that work?
— Reply to this email directly, view it on GitHub https://github.com/oras-project/oras-py/issues/117#issuecomment-1816897173, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBTO52TWTRIQRCSAGLSH23YE6UCXAVCNFSM6AAAAAA7QFV2DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHA4TOMJXGM . You are receiving this because you authored the thread.Message ID: @.***>
I found another instance off missing the verify arg on line 988 of that same file
On Fri, Nov 17, 2023 at 11:43 AM Vanessasaurus @.***> wrote:
Done.
— Reply to this email directly, view it on GitHub https://github.com/oras-project/oras-py/issues/117#issuecomment-1816916806, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBTO556PNIDTXGWGHIMCC3YE6V6XAVCNFSM6AAAAAA7QFV2DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHEYTMOBQGY . You are receiving this because you authored the thread.Message ID: @.***>
I'm having trouble getting that added without trigger the pre-commit tests to pass (the noqa doesn't work). if you can give it a try when you are back at keyboard for something that works it would be appreciated!
Yeah I changed that line to:
authResponse = self.session.get(h.realm, verify=self._tls_verify, headers=-headers, params=params)
Does that work for you?
On Fri, Nov 17, 2023 at 1:00 PM Vanessasaurus @.***> wrote:
I'm having trouble getting that added without trigger the pre-commit tests to pass (the noqa doesn't work). if you can give it a try when you are back at keyboard for something that works it would be appreciated!
— Reply to this email directly, view it on GitHub https://github.com/oras-project/oras-py/issues/117#issuecomment-1817013031, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBTO56VCBCRSAPXF3SCUV3YE667JAVCNFSM6AAAAAA7QFV2DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGAYTGMBTGE . You are receiving this because you authored the thread.Message ID: @.***>
okay updated - and I just removed mypy. It's more pain than it's worth I think.