oras-go icon indicating copy to clipboard operation
oras-go copied to clipboard

Migrate to OCI Artifact from ORAS Artifact

Open shizhMSFT opened this issue 3 years ago • 8 comments

We will migrate to OCI Artifact from ORAS Artifact once the following PRs are merged.

  • https://github.com/opencontainers/image-spec/pull/934
  • https://github.com/opencontainers/distribution-spec/pull/335

Tasks:

  • [x] #307
  • [x] #308
  • [x] #309
  • [x] #310
  • [x] #311
  • [ ] #312
  • [ ] #347

This issue covers #267 and #268.

shizhMSFT avatar Aug 18 '22 03:08 shizhMSFT

Should we start a new branch for OCI now that you have go structs for OCI. Similarly, for oras - CLI? /cc @nima @michaelb990 @shizhMSFT

sajayantony avatar Aug 26 '22 00:08 sajayantony

Any update on this work?

rdpsin avatar Aug 31 '22 18:08 rdpsin

@rdpsin We will be working on this after releasing oras-go v2.0.0-rc3, which is scheduled for Sep. 5th.

Wwwsylvia avatar Sep 01 '22 02:09 Wwwsylvia

Just a clarification that we'll need to maintain support for ORAS artifacts, until all registries have migrated to the OCI Artifact spec.

  1. Check if /referrers is supported (best future case)
  2. Check if _oras/referrers is supported (limited time, as ACR, ECR and Zot migrate to /referrers)
  3. Fallback to using OCI Image manifest, with a refers/subject property (see Rename refers field to subject #950)

SteveLasker avatar Sep 13 '22 18:09 SteveLasker

Just a clarification that we'll need to maintain support for ORAS artifacts, until all registries have migrated to the OCI Artifact spec.

  1. Check if /referrers is supported (best future case)
  2. Check if _oras/referrers is supported (limited time, as ACR, ECR and Zot migrate to /referrers)
  3. Fallback to using OCI Image manifest, with a refers/subject property (see Rename refers field to subject #950)

The initial iteration will not have the fallback to ORAS Artifact referrers. The fallback will be added in the second iteration after proper discussions.

shizhMSFT avatar Sep 19 '22 06:09 shizhMSFT

Oras needs to consume RC2 since it includes the subject field - https://github.com/opencontainers/image-spec/pull/958

sajayantony avatar Sep 28 '22 00:09 sajayantony

The fallback will be added in the second iteration after proper discussions.

What fallback are we talking about here? From what I read, it seemed like falling back to ORAS Artifacts wouldn't be compatible with the tag-based fallback already proposed in the OCI distribution-spec, now an RC.

michaelb990 avatar Sep 28 '22 01:09 michaelb990

On the call today we discussed that the fall back to ORAS is not going to be supported. This issues needs to be updated to reflect that and the next update to the libraries will remove the ORAS artifact types and move to OCI with OCI image fallback.

sajayantony avatar Sep 28 '22 03:09 sajayantony

Closing as all sub tasks are resolved.

shizhMSFT avatar Oct 31 '22 11:10 shizhMSFT