oranenj

@piwi3910 I've never used ansible's virt module so I opted to go with virt-install because it's what I know, but if ansible can handle the provisioning, that ought to integrate...

Actually now that I think about it, I can have virt-install print out the xml it uses to launch the installation and templatize that. I already replaced most of the...

Looks like virt-install writes out two domains: the first being the ephemeral one that's told to kickstart, and the second being the persistent virtual machine definition, so you'd have to...

@NeilHanlon @samveen for build hosts, the idea is to add an additional disk (or at least a logical volume) mounted on /var/mock directly. This kickstart only concerns itself with the...

Is there anything that blocks merging this script in its current form? The kickstart can be extended later to include all kinds of options and more advanced logic, or (more...

I'm not going to implement either foreman or cobbler within this pull request though :P Its point is to just have something that can create VMs to get things started.

What are the automatic tools that could help enforce this? For shell scripts, running at least ShellCheck is probably a good idea.

I tried running the tests with Debian 10, but they seem to fail for whatever reason. I don't see why this module wouldn't work on Debian, but unless someone steps...

@myMarck are those port definitions local modifications using a previous Puppet manifest or in the system policy? The SELinux module can't remove system definitions, only local customizations.

If you want to change the port definitions, you can add a definition that assigns the ports to some other SELinux type