Oran Agra
Oran Agra
I agree it's a slightly different topic than (sorry for hogging your issue). It's just that your opening statement made me realize we missed a big issue with cluster in...
going though this again i'd like to summarize and suggest what i think should be done. i'd like to use Ran's idea of adding a metadata field to the function...
@madolson by slot independent data you mean some per-slot data storage (i.e. the function will be able to store some info in slot 0 and some info in slot 1)?...
ok, i can live with that.. it does make things a little bit more complex (more steps), and adds backwards compatibility issues, but arguably makes things clearer. so a function...
discussed in core-team meeting. we wanna tackle these 3 separate topics together as part of 7.2. the `get_slot_range()` thing, might be an anti-pattern, we should try to think if we...
@jun0315 thank you for the PR. I only skimmed through the code, so forgive me if I'm making false assumptions. Before starting the real discussion about the pros and cons...
@redis/core-team please comment / approve.
approved in a core-team meeting. we concluded that since 7.2 is gonna have rdb format changes anyway (#11290), then we can afford changing the streams rdb format as well. shall...
IIRC the comments i gave there are quite substantial, so maybe take the safe route and merge change the rdb part in a separate PR after it becomes a reality.
i don't think the damage in the blame log is high, just a couple of comments to delete. plus the fact that the rdb change is added in a different...