Yichen Yan

Results 72 comments of Yichen Yan

@pytorchbot merge

@pytorchbot merge

We do sometimes want pure `pth` solution, i.e. to have full src and build artifacts in source folder. Meantime, we also want to set 'build-dir' when using `editable.mode = "inplace"`...

cython issue: https://github.com/cython/cython/issues/6861

> Would that be enough to fix the PyTorch issue (I certainly hope so since it seemed to be a regression in 6.3.0) ? it's enough for upstream PyTorch but...

It should be fine then? The reason is I'm using `sorted(needed)` rather than the `DT_NEEDED` order, so now it should just work?

Thanks! I've committed your dynamo fix, and I'll look at the failed test.

This is ready to be reviewed again :) @pacman100

> We expect `enabled` in the compile config is boolean but `auto` is passed to `Init` (`'compile': {'enabled': 'auto', 'backend': 'auto'}`). That sounds like I'm initializing the config in wrong...

not stale, still working on that