weblogic-kubernetes-operator icon indicating copy to clipboard operation
weblogic-kubernetes-operator copied to clipboard

Replace direct references to 'kubectl' and 'docker' executables with …

Open tbarnes-us opened this issue 2 years ago • 1 comments

These changes include:

  • Updating sample & test java and scripts.
  • Changing references to docker or kubectl to KUBERNETES_CLI and WLSIMG_BUILDER respectively.
  • Changing method names and comment text that include variations of 'kubectl' or 'docker' to something more generic.
  • Adding a ./validateCLI.sh build check in 'pom.xml' to check for invalid direct use of 'docker', 'Docker', 'DOCKER', or 'kubectl', 'Kubectl', or 'KUBECTL'. This script can also be run stand-alone.

These changes deliberately do not include:

  • Updating documentation.

  • Updating lines that are part of a comment (many were changed, but not all).

  • Updating the more specialized KUBECTL usages, such as: -- the 'KUBECTL_VERSION' global -- the 'kubectl.kubernetes.io.last-applied-configuration' annotation

  • Updating the more specialized docker usages, such as: -- var name 'dockerFile' and filename 'Dockerfile' -- script name create-docker-credentials-secret.sh, buildDockerImage.sh, ... -- default secret name 'docker-store'

See the "sed filters" in ./validateCLI.sh for the full list.

See also:

WebLogic Image Tool pull: https://github.com/oracle/weblogic-image-tool/pull/393

tbarnes-us avatar Oct 07 '22 21:10 tbarnes-us

Did the tests run cleanly? Is this change ready to be merged?

rjeberhard avatar Oct 19 '22 21:10 rjeberhard

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 22 '22 12:10 sonarqubecloud[bot]

@tbarnes-us, what's the status of this change? I can help with the merge, but I'm not sure whether it's otherwise ready to go.

rjeberhard avatar Nov 30 '22 15:11 rjeberhard

@rjeberhard This is ready to merge. All expected tests pass. (There are two "parallel" integration test failures in FMW domain-in-image testing, but, according to the QA team, they are a known/expected issue.)

tbarnes-us avatar Dec 01 '22 16:12 tbarnes-us

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 01 '22 16:12 sonarqubecloud[bot]