weblogic-kubernetes-operator
weblogic-kubernetes-operator copied to clipboard
Replace direct references to 'kubectl' and 'docker' executables with …
These changes include:
- Updating sample & test java and scripts.
- Changing references to docker or kubectl to KUBERNETES_CLI and WLSIMG_BUILDER respectively.
- Changing method names and comment text that include variations of 'kubectl' or 'docker' to something more generic.
- Adding a
./validateCLI.sh
build check in 'pom.xml' to check for invalid direct use of 'docker', 'Docker', 'DOCKER', or 'kubectl', 'Kubectl', or 'KUBECTL'. This script can also be run stand-alone.
These changes deliberately do not include:
-
Updating documentation.
-
Updating lines that are part of a comment (many were changed, but not all).
-
Updating the more specialized KUBECTL usages, such as: -- the 'KUBECTL_VERSION' global -- the 'kubectl.kubernetes.io.last-applied-configuration' annotation
-
Updating the more specialized docker usages, such as: -- var name 'dockerFile' and filename 'Dockerfile' -- script name create-docker-credentials-secret.sh, buildDockerImage.sh, ... -- default secret name 'docker-store'
See the "sed filters" in ./validateCLI.sh
for the full list.
See also:
WebLogic Image Tool pull: https://github.com/oracle/weblogic-image-tool/pull/393
Did the tests run cleanly? Is this change ready to be merged?
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@tbarnes-us, what's the status of this change? I can help with the merge, but I'm not sure whether it's otherwise ready to go.
@rjeberhard This is ready to merge. All expected tests pass. (There are two "parallel" integration test failures in FMW domain-in-image testing, but, according to the QA team, they are a known/expected issue.)
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication