Enhance the MII sample pod wait script for 4.0

[tbarnes-us]

Changes:

• Rely on a domain reaching its 'Complete' condition instead of requiring user to pass in the expected pod count
• Check that the domain generation and observedGeneration match
• Check that the domain api version is at least v9
• Fail fast by default if a 'Failed' condition is detected.

[tbarnes-us]

NOTE: This is converted to 'draft' as there are issues in the new 4.0 operator conditions that in turn make this change unstable (as this change depends on conditions). I have reproduced using the latest Operator version and have filed a corresponding internal JIRA task.

[tbarnes-us]

Minor side comments about potential further minor improvements (lower priority - may be added as time permits):

• Simplify: Replace use of temporary files by populating internal results into an env var instead.
• Clarify: Update usage to clearly mention that the script checks generation vs. observedGeneration.
• Simplify: Create log helper function for replacing 'echo timestamp ...' style lines.
• Fix: Usage should get defaults from default constants - it is currently using vars that might change when the command line is processed.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[tbarnes-us]

Closing - moved to different branch/pull OWLS-88344-new