terraform-kubernetes-installer icon indicating copy to clipboard operation
terraform-kubernetes-installer copied to clipboard

add support for multiple compartments as per sod

Open srirg opened this issue 7 years ago • 1 comments

This PR is a fix for https://github.com/oracle/terraform-kubernetes-installer/issues/166

srirg avatar Mar 23 '18 15:03 srirg

I'm not sure the multiple_compartments flag is needed. Can you just use the value if set? e.g:-

network_compartment_ocid = "${(var.network_compartment_ocid != "") ? var.network_compartment_ocid : var.compartment_ocid}"

Also can you rebase + squash to master and split the functionally out into a clean merge request with structured descriptive commit message(s). At the moment this change has many features including a bastion change with many unneeded commit messages.

Thanks

garthy avatar Mar 27 '18 09:03 garthy