railcar icon indicating copy to clipboard operation
railcar copied to clipboard

Implement eq and as_str in LinuxCapabilityType

Open josselinchevalay opened this issue 7 years ago • 11 comments

i created an issue https://github.com/oracle/railcar/issues/36

for solved that i propose this pull request let me know your advice.

Regards

josselinchevalay avatar Mar 20 '18 10:03 josselinchevalay

Is anything blocking this right now?

drahnr avatar Sep 17 '18 12:09 drahnr

I don't believe @josselinchevalay has signed the CLA so I can't merge. That said, I don't follow the updated logic. If difference is working properly, the if statement on the second line should always be false.

vishvananda avatar Sep 17 '18 18:09 vishvananda

I did not look into the code itself, just wondering why this is dangling :)

drahnr avatar Sep 17 '18 19:09 drahnr

hi all,

yep second if statement seems return false always, i didn't why ? for CLA how to signed ?

Regards

josselinchevalay avatar Sep 18 '18 06:09 josselinchevalay

Instructions and a link to the OCA info can be found on the contributing page:

https://github.com/oracle/railcar/blob/master/CONTRIBUTING.md

vishvananda avatar Sep 25 '18 17:09 vishvananda

but yes i still don't think this new logic is correct.

vishvananda avatar Sep 25 '18 17:09 vishvananda

@josselinchevalay it's been a while, any news?

drahnr avatar Jun 22 '19 10:06 drahnr

@drahnr nop i need to sign CLA. do you have same issue ?

josselinchevalay avatar Jul 23 '19 09:07 josselinchevalay

I already signed the CLA :)

drahnr avatar Jul 23 '19 10:07 drahnr

ok for me that solved my issue with caps errors

josselinchevalay avatar Jul 23 '19 15:07 josselinchevalay

Could you add print statement and show the two prints of the old and new logic. I am not quite sure what should differ between both of them.

drahnr avatar Jul 23 '19 20:07 drahnr