opengrok icon indicating copy to clipboard operation
opengrok copied to clipboard

smarter detection of CVS repository

Open Shooter3k opened this issue 6 years ago • 7 comments

I have a folder called "CVS" that refuses to index. I've removed the ignoredNames property from the configuration file and they just get added right back when I re-index.

Why do they add themselves back in? How do I index a folder called "CVS" ?

lines removed from configuration.xml file:

     <void method="add">
      <string>CVS</string>
     </void>
     <void method="add">
      <string>CVSROOT</string>
     </void>

Shooter3k avatar Dec 12 '18 17:12 Shooter3k

Looks like #1458. I don't think this is possible given that CVSrepository constructor does this:

78          ignoredFiles.add(".cvsignore");
79          ignoredDirs.add("CVS");
80          ignoredDirs.add("CVSROOT");

vladak avatar Dec 12 '18 18:12 vladak

What is your use case ?

vladak avatar Dec 12 '18 18:12 vladak

What do you mean? I have a folder in our repository that's called "CVS" that needs to be indexed and it won't let me index it.

What is your use case ?

Shooter3k avatar Dec 12 '18 18:12 Shooter3k

Okay, it is just a coincidence, not a CVS repository metadata directory.

vladak avatar Dec 12 '18 20:12 vladak

CVSrepository#isRepositoryFor() is


138          if (file.isDirectory()) {
139              File cvsDir = new File(file, "CVS");
140              return cvsDir.isDirectory();
141          }
142          return false;

It should probably check also some of the contents of the CVS directory.

Also, the ignored directories need some other treatment.

vladak avatar Dec 12 '18 20:12 vladak

Is there any way to work around this issue and get the folder to be indexed?

I'm confused about this being an enhancement without a workaround but who am I to argue.

Shooter3k avatar Dec 12 '18 20:12 Shooter3k

I cannot think of any workaround.

There is not much difference whether an issue is marked as bug or enhancement. It only counts whether someone is working on it :-)

vladak avatar Dec 12 '18 20:12 vladak