oci-service-operator icon indicating copy to clipboard operation
oci-service-operator copied to clipboard

CR Deletion is reported as an error

Open liafizan opened this issue 2 years ago • 0 comments

Hello there!

Do we have to report CR deletion as an error? I created a stream object and deleted it but operator reported not found as an error.

2022-05-12T22:52:23.152Z    DEBUG    controllers.Streams     {  Message: Fetching the resource from server , name: osok-stream , namespace: oci-operators }                                                      │
│ 2022-05-12T22:52:23.152Z    ERROR    controllers.Streams     {  Message: The resource could be in deleting state. Ignoring , name: osok-stream , namespace: oci-operators }     {"error": "Stream.oci.oracle.com │
│ github.com/go-logr/zapr.(*zapLogger).Error                                                                                                                                                                       │
│     /workspace/vendor/github.com/go-logr/zapr/zapr.go:132                                                                                                                                                        │
│ github.com/oracle/oci-service-operator/pkg/loggerutil.(*OSOKLogger).ErrorLog                                                                                                                                     │
│     /workspace/pkg/loggerutil/logger.go:89                                                                                                                                                                       │
│ github.com/oracle/oci-service-operator/pkg/core.(*BaseReconciler).Reconcile                                                                                                                                      │
│     /workspace/pkg/core/reconciler.go:53                                                                                                                                                                         │
│ github.com/oracle/oci-service-operator/controllers.(*StreamReconciler).Reconcile                                                                                                                                 │
│     /workspace/controllers/stream_controller.go:37                                                                                                                                                               │
│ sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler                                                                                                                            │
│     /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:263                                                                                                                   │
│ sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem                                                                                                                         │
│     /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:235                                                                                                                   │
│ sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.1                                                                                                                               │
│     /workspace/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:198                                                                                                                   │
│ k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1                                                                                                                                                   │
│     /workspace/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:185                                                                                                                                              │
│ k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1                                                                                                                                                             │
│     /workspace/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:155                                                                                                                                              │
│ k8s.io/apimachinery/pkg/util/wait.BackoffUntil                                                                                                                                                                   │
│     /workspace/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:156                                                                                                                                              │
│ k8s.io/apimachinery/pkg/util/wait.JitterUntil                                                                                                                                                                    │
│     /workspace/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133                                                                                                                                              │
│ k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext                                                                                                                                                         │
│     /workspace/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:185                                                                                                                                              │
│ k8s.io/apimachinery/pkg/util/wait.UntilWithContext                                                                                                                                                               │
│     /workspace/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:99

Perhaps this should be informational

liafizan avatar May 12 '22 23:05 liafizan