node-oracledb icon indicating copy to clipboard operation
node-oracledb copied to clipboard

Setting connection.module to undefined failes

Open ReneBeszon opened this issue 3 years ago • 1 comments

Dear all,

reading the documentation from connection.module setting it to undefined is allowed

image

but when doing so, it results in a database error

NJS-004: invalid value for property module

when setting to "" everything works fine.

ReneBeszon avatar Jul 05 '22 12:07 ReneBeszon

Our doc https://oracle.github.io/node-oracledb/doc/api.html#propconnmodule carefully doesn't mention anything about undefined.

It seems you are showing the Typescript definition from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/oracledb. Can you open an issue there and ping @dannyb648? I also see @sla100 has made some contributions.

cjbj avatar Jul 08 '22 07:07 cjbj

This issue has been automatically marked as inactive because it has not been updated recently. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 12 '22 02:08 stale[bot]

Closing. As mentioned, this should be reported about the typescript definition file.

cjbj avatar Aug 12 '22 06:08 cjbj