Upload File command should show an error if upload fails

[michoelchaikin]

Your environment

SuiteCloud Extension for Visual Studio Code v1.0.3

Describe the bug

If the Upload File command fails (for example due to a syntax error in the file), the VS Code extension still displays the message, "'Upload File' has been successfully executed").

To Reproduce

Create a suitescript file with a syntax error, and then try run the command SuiteCloud: Upload File

Actual Behavior

The file fails to upload, however, this is not reflected in the message.

Expected Behavior

It's expected that if the file upload failed, an error message should be shown instead to inform the user of such.

[alisyed-19]

This is not a bug. The pop-up just informs that the command execution has finished successfully. See details for more information. But I understand this can be misleading. We will see if this can be enhanced.