netsuite-suitecloud-sdk icon indicating copy to clipboard operation
netsuite-suitecloud-sdk copied to clipboard

Unix style line endings

Open rntgspr opened this issue 3 years ago • 3 comments

Your environment

OS : MacOS Big Sur 11,1 Node.js version : 12.14.1 suitecloud-cli version : latest Terminal/CMD tool : iTerm

Describe the bug

Just faced an error using suitecloud cli inside project folder directory on MacOS BigSur 11.1

To Reproduce

$ cd ~/your-project-directory
$ yarn add @oracle/suitecloud-cli
$ ./node_modules/.bin/suitecloud account:manageauth --list

Actual Behavior

env: node\r: No such file or directory

Expected Behavior

<list of current authentication id's>

Additional context

It happens when module is installed on project directory. After file is fixed (adding a line after the first line and saving) everything works as expected.

rntgspr avatar Apr 15 '21 18:04 rntgspr

@rntgspr Thanks for reporting this, when you say After file is fixed (adding a line after the first line and saving) everything works as expected Which file are you editing and adding a new line?

alisyed-19 avatar Apr 20 '21 11:04 alisyed-19

Sorry, I should put it there, https://github.com/oracle/netsuite-suitecloud-sdk/blob/master/packages/node-cli/src/suitecloud.js

Adding a line after line 1

rntgspr avatar Apr 20 '21 17:04 rntgspr

One year later, this is somehow still an issue?

  • suitecloud.js is not marked executable (requiring the user to manually chmod +x the package entry point)
  • suitecloud.js has dos line endings causing it to fail to run for linux and mac users (requiring the user to dos2unix the package entry point).

Y'all need a PR or something?

sberlan-odeko avatar Sep 06 '22 21:09 sberlan-odeko