mysql-operator icon indicating copy to clipboard operation
mysql-operator copied to clipboard

Published 20 hours ago • verified publisher icon oracle

Add spellcheck tests

Open KashifSaadat opened this issue 6 years ago • 3 comments

Changes:

  • Added misspell library and extend tests to perform a spellcheck on golang and markdown files (vendor directory is excluded)
  • Updated docs where the spellcheck test detected typos.

KashifSaadat avatar Sep 28 '18 15:09 KashifSaadat

Kept the commits separate so they're easier to review.

KashifSaadat avatar Sep 28 '18 15:09 KashifSaadat

Thanks for the PR @KashifSaadat 😄!

Would you mind splitting it out into two separate PRs as the two changes are unrelated as far as I can see?

Additionally, we'll probably want to update the CI image to include a prebuilt misspell binary rather than go installing it every time. There's no automation set up for building the CI images so I'm happy to pick up that part of the change if you're happy with me doing so?

prydie avatar Oct 01 '18 12:10 prydie

Hey @prydie, sure that sounds good. I've raised PR #229 with the commit for the RBAC template updates. Shall we close this PR in favour of your CI image update?

KashifSaadat avatar Oct 03 '18 10:10 KashifSaadat