graalvm-reachability-metadata icon indicating copy to clipboard operation
graalvm-reachability-metadata copied to clipboard

Add support for `ch.qos.logback:logback-core:1.2.12`

Open linghengqian opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

  • No.

Describe the solution you'd like A clear and concise description of what you want to happen.

  • Add support for ch.qos.logback:logback-core:1.2.12.
  • The relevant JSON entry is available at https://github.com/apache/shardingsphere/tree/0397f829d60b47cd57b255a4f48132d627e7b10c/infra/reachability-metadata/src/main/resources/META-INF/native-image/ch.qos.logback/logback-core/1.2.12 .

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

  • Null.

Additional context Add any other context or screenshots about the feature request here.

  • Refer to https://github.com/apache/shardingsphere/issues/29052 .

linghengqian avatar Feb 12 '24 08:02 linghengqian

  • I'm working on this issue.

linghengqian avatar Feb 12 '24 08:02 linghengqian

Some configuration is also manually configured in different project. See: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core/src/main/resources/META-INF/native-image/com.azure/azure-core/native-image.properties#L4-L14 We could copy-paste configuration.

tjuchniewicz avatar Aug 01 '24 11:08 tjuchniewicz

Some configuration is also manually configured in different project. See: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core/azure-core/src/main/resources/META-INF/native-image/com.azure/azure-core/native-image.properties#L4-L14 We could copy-paste configuration.

  • Just a friendly reminder that native-image.properties is not part of the general GraalVM Reachability Metadata. See https://github.com/oracle/graalvm-reachability-metadata/blob/0.3.8/CONTRIBUTING.md#checklist .

All other library tweaks (such as build time initialization through native-image.properties) must not be included here. By default, it should be assumed that all user libraries are runtime initialized. Build-time initialization can not be included as it does not compose and can break code in unpredictable ways.

  • The contents of --initialize-at-build-time actually belong to the buildArg of the native-image command line tool.
  • The reason why the current issue is not updated is simply because I don’t have time. If you are ready to make a PR, just submit it.

linghengqian avatar Aug 01 '24 15:08 linghengqian