graalvm-reachability-metadata icon indicating copy to clipboard operation
graalvm-reachability-metadata copied to clipboard
verified publisher icon oracle

Add support for `org.apache.zookeeper:zookeeper:3.8.1`

Open linghengqian opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

  • ~Yes, this is a pre-issue to https://github.com/oracle/graalvm-reachability-metadata/issues/163 .~

  • Since Zookeeper Server 3.8.1 includes critical https://issues.apache.org/jira/browse/ZOOKEEPER-4460 to fix GraalVM nativeTest. Refer to https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12351398&styleName=Html&projectId=12310801 .

Describe the solution you'd like A clear and concise description of what you want to happen.

  • Add support for org.apache.zookeeper:zookeeper:3.8.1.
  • The relevant JSON entry is available at https://github.com/apache/shardingsphere/tree/0397f829d60b47cd57b255a4f48132d627e7b10c/infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.zookeeper/zookeeper/3.9.0 .

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

  • Null.

Additional context Add any other context or screenshots about the feature request here.

  • Metadata generated at https://github.com/linghengqian/graalvm-trace-metadata-smoketest/issues/1 .

  • Linkes to https://github.com/apache/shardingsphere/issues/21347 and https://github.com/apache/shardingsphere/issues/29052 .

linghengqian avatar Jan 26 '23 01:01 linghengqian

  • I'm working on this issue.

linghengqian avatar Jan 26 '23 01:01 linghengqian

@linghengqian Any updates on this issue? :)

iNikem avatar Feb 12 '24 12:02 iNikem

@linghengqian Any updates on this issue? :)

  • As a ShardingSphere Committer, the relevant metadata actually exists on the Apache ShardingSphere side for a long time, and the ShardingSphere side also has a small test set to verify the availability of the relevant metadata JSON. Reference https://github.com/apache/shardingsphere/tree/0397f829d60b47cd57b255a4f48132d627e7b10c/infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.zookeeper/zookeeper/3.9.0 .
  • As a student, I don’t have much time to handle multiple issues at the same time. I don't actually have merge permissions for the current repository. I have been waiting for the open PR on this repository for 6 months and have not received any review comments. Reference https://github.com/oracle/graalvm-reachability-metadata/pull/388 .
  • If you need this part of JSON now, you can copy the relevant JSON to your own project.
  • In the past 6 months, I could not find a committer in the current repo who was free to review my PR, so the GraalVM Reachability Metadata involved in the issue I opened was submitted to the ShardingSphere side by me.
  • If you have time, you can just write additional test suites, submit a PR and close this issue. Obviously as a student, I really don’t have that much energy to wait for multiple PR reviews.

linghengqian avatar Feb 12 '24 12:02 linghengqian

Please, see this

dnestoro avatar Feb 12 '24 13:02 dnestoro

  • I confirmed in https://github.com/apache/shardingsphere-elasticjob/pull/2428 that https://github.com/apache/shardingsphere/blob/cb729ed63f234118202d41210f3ffdba035286b1/infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.zookeeper/zookeeper/3.9.0/reflect-config.json is not all the GraalVM Reachability Metadata required by Zookeeper. Once trying to connect to Zookeeper Server with DIGEST-MD5 as SASL mechanism, JAAS related GraalVM Reachability Metadata is missing for Zookeeper Client.

  • To be honest, this is my first time to touch such an old thing as JAAS under GraalVM Native Image, and the SASL mechanism in JAAS is even more niche. Perhaps it is necessary to initiate relevant investigation in the ASF JIRA of apache/zookeeper and apache/curator . After all, the Kafka Client of apache/kafka can connect to the Kafka Server with SASL mechanism enabled under GraalVM Native Image. I will of course assume that the Kafka Native Server in the form of the GraalVM Native Image that has been announced to be generally available solves the problem with the SASL mechanism.

  • But then again, the PMC of apache/curator is migrating the issue tracker, so it may take some time to wait. See https://x.com/tison1096/status/1821834353917206865 and https://lists.apache.org/thread/jky33br972m1nwbnp9cjfzl9vlrmrt85 .

  • I think I will resolve this issue before GraalVM CE For JDK29 is released.

linghengqian avatar Aug 13 '24 01:08 linghengqian