graal icon indicating copy to clipboard operation
graal copied to clipboard

[GR-52034] Update IGV to netbeans 20 and JDK 21

Open graalvmbot opened this issue 1 year ago • 1 comments

Update the base of IGV to netbeans 20 and support JDK11 through JDK21.

graalvmbot avatar Feb 12 '24 21:02 graalvmbot

I can make that problem go away by duplicating the import of net.java.html in the project.xml, which is bizarre. It normally fails

$ mx unittest |& grep net.java.html
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html was needed and not found.
    [junit] 	org.graalvm.visualizer.settings - The module named net.java.html.json was needed and not found.
    [junit] 	Settings - The module named net.java.html was needed and not found.
    [junit] 	Settings - The module named net.java.html.json was needed and not found.

adding a duplicate of the first entry

$ git diff
diff --git a/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml b/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml
index eeae021df47..f836b2dab0d 100644
--- a/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml
+++ b/visualizer/IdealGraphVisualizer/Settings/nbproject/project.xml
@@ -6,6 +6,14 @@
             <code-name-base>org.graalvm.visualizer.settings</code-name-base>
             <suite-component/>
             <module-dependencies>
+                <dependency>
+                    <code-name-base>net.java.html</code-name-base>
+                    <build-prerequisite/>
+                    <compile-dependency/>
+                    <run-dependency>
+                        <specification-version>1.8.1</specification-version>
+                    </run-dependency>
+                </dependency>
                 <dependency>
                     <code-name-base>net.java.html</code-name-base>
                     <build-prerequisite/>

then causes it to successfully load those modules. It fails for other unrelated reasons. Obviously something weird is going on. Any suggestions?

tkrodriguez avatar Feb 14 '24 19:02 tkrodriguez