cluster-api-provider-oci icon indicating copy to clipboard operation
cluster-api-provider-oci copied to clipboard

feat: add MachineExternalIP to status

Open BobyMCbobs opened this issue 1 year ago • 1 comments

add MachineExternalIP address to OCIMachine status

What this PR does / why we need it:

when available, writes the public machine IP address to the status along with the private IP address.

Resolves usage with Talos bootstrap+controlplane cluster-api provider.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #379

BobyMCbobs avatar Sep 02 '24 22:09 BobyMCbobs

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.