squeeth-monorepo icon indicating copy to clipboard operation
squeeth-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon opynfinance

Pnl bands

Open KMKoushik opened this issue 2 years ago • 5 comments

Task:

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes ENG-1362

Type of change

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Testing code
  • [ ] Document update or config files

KMKoushik avatar Jan 24 '23 21:01 KMKoushik

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
continuouscall ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 11:43PM (UTC)

vercel[bot] avatar Jan 24 '23 21:01 vercel[bot]

ENG-1362 Update PnL Bands to include deposit date to take into account different bands for new users, users depositing after last hedge, and existing users

Screen Shot 2023-01-13 at 4.01.22 PM.png

Screen Shot 2023-01-13 at 4.05.18 PM.png

Qs from the chat:

  1. Is deposit date/time going to be the timestamp of the latest deposit or the first one?
    1. Once a user is in the strategy they all have the same bands, so for an existing user who has multiple deposits into the strategy, we can show the latest deposit timestamp but the bands will be the same for their whole position if wallet connected
    2. For a user who is already in the strategy and deposited after the last hedge, we should show the worse timestamp + bands if wallet connected
  2. For the exact math and formulas, generally the bands should be wider for a new user but have the same center as the existing, and can ask Andrew + Joe on the exact math

Figma:

Date Picker - Switch Order - Crabby testin (Figma)

linear[bot] avatar Jan 25 '23 06:01 linear[bot]

We should do this for bull as well! Just noticed its not done there yet - can be finalized for crab first and then copy / pasted over, but imo we shld launch with both

alexisgauba avatar Jan 28 '23 01:01 alexisgauba

Also for users already in the strategy, the deposit date should be the date they deposited when their wallet is connected. This account has a test position but its showing today's date not deposit date

Screen Shot 2023-01-27 at 5 14 44 PM

alexisgauba avatar Jan 28 '23 01:01 alexisgauba

Looks like the tooltip is still doin dis weird thing, maybe we want the tooltip above the background stuffs?

Screen Shot 2023-02-02 at 9 28 15 PM

alexisgauba avatar Feb 03 '23 05:02 alexisgauba