squeeth-monorepo icon indicating copy to clipboard operation
squeeth-monorepo copied to clipboard

New implementation of current sqth amount and PNL calculation

Open deepthinker250 opened this issue 2 years ago • 3 comments

Task:

Description

Implement PNL using subgraph and integrate it on the Frontend

Fixes # (issue)

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Document update

How Has This Been Tested

Please describe how to test to verify the changes. Provide instructions so we can reproduce.

FE Checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] Added video recordings if it is a UI change

User Facing Checklist

  • [ ] I fully understand the user problem this PR is solving
  • [ ] I know who the target user is for this PR and have a deep understanding of that user
  • [ ] I have tried this flow thinking from the pov of the target user for this PR
  • [ ] I (or working w someone on team) have scheduled a user test for this PR (if it is a large change)

deepthinker250 avatar Jul 18 '22 14:07 deepthinker250

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
continuouscall ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 8:06PM (UTC)

vercel[bot] avatar Jul 18 '22 14:07 vercel[bot]

To check if it's working we can check with onchain value, If there's a mismatch we can show the onchain value and add event to the fathom so we can analyze it

great idea. i like this

akwritescode avatar Aug 11 '22 21:08 akwritescode

ok so not fathom but we could add to sentry. can you please add that code @adam5909099 so that we can try to get this merged after that?

akwritescode avatar Sep 01 '22 14:09 akwritescode