squeeth-monorepo icon indicating copy to clipboard operation
squeeth-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon opynfinance

fix: fe liquidity txs not showing issues

Open yichiehliu opened this issue 2 years ago • 7 comments

Task:

Description

  1. add useLiquidityTxHistory hook, handling lp txs pulling and calculations

Fixes #330 (issue)

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Document update

How Has This Been Tested

Locally with address having lp txs history

Checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] Added video recordings if it is a UI change

yichiehliu avatar Apr 18 '22 12:04 yichiehliu

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
continuouscall ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 9:36AM (UTC)

vercel[bot] avatar Apr 18 '22 12:04 vercel[bot]

Can you explain more about the fix? High level it looks like you moved the function and added a subscription. Does subscription fix the issue?

@EstherSeyi Was mentioning something about a subscription is not working in some cases, can you sync with her and let me know if that's not the problem here?

yh subscription fixed the issue, but it's a bit hard to debug with subscription cuz we dont know what it does underneath the hood, but pulling may not be good for performance, I am trying to come up with better solutions with either subscription or pulling

Would love to know if any thoughts/suggestions @KMKoushik @adam5909099 @EstherSeyi @block902

yichiehliu avatar Apr 20 '22 06:04 yichiehliu

It doesn't seem to be working for me. In the screenshot below, I just opened an lp position, but it doesn't show up in the transactions.

Screenshot 2022-04-25 at 09 38 13

EstherSeyi avatar Apr 25 '22 08:04 EstherSeyi

It doesn't seem to be working for me. In the screenshot below, I just opened an lp position, but it doesn't show up in the transactions.

Screenshot 2022-04-25 at 09 38 13

@EstherSeyi Could u try this link? https://continuouscall-q2bo64a51-opynfinance.vercel.app

yichiehliu avatar Apr 25 '22 08:04 yichiehliu

continuouscall-q2bo64a51-opynfinance.vercel.app

I'm experiencing the same thing here too

EstherSeyi avatar Apr 25 '22 09:04 EstherSeyi

Also please focus on 3 start issues before working on this.

KMKoushik avatar Apr 26 '22 23:04 KMKoushik

Is there a way to add some tests so that it's not happening again?

yh, was working on the tests, will be focusing on 3 star issues first and come back here after those fixes!

yichiehliu avatar Apr 26 '22 23:04 yichiehliu