squeeth-monorepo icon indicating copy to clipboard operation
squeeth-monorepo copied to clipboard

Different values from short trade modal & position card

Open yichiehliu opened this issue 3 years ago • 2 comments

Describe the bug The position card gets the value from swaps data / vaultHistories, the modal gets the value from uniswap trade simulation, so there is some gaps between two numbers

To Reproduce Steps to reproduce the behavior:

  1. Open short position on trade page

Expected behavior Values shld be the same

Screenshots image

Additional context Add any other context about the problem here.

yichiehliu avatar Feb 21 '22 02:02 yichiehliu

@yichiehliu I think it's not possible. It's not simulation it just gets the quote and we never get the same value because of slippage.

KMKoushik avatar Apr 14 '22 01:04 KMKoushik

May be we can fetch what happened in the tx and show it in the trade modal

KMKoushik avatar Apr 14 '22 01:04 KMKoushik