ConvexityProtocol icon indicating copy to clipboard operation
ConvexityProtocol copied to clipboard

Published 20 hours ago • verified publisher icon opynfinance

Reentrancy in OptionsContract.addERC20Collateral(address,uint256) (OptionsContract.sol#357-370)

Open ghost opened this issue 4 years ago • 0 comments

Reentrancy in OptionsContract.addERC20Collateral(address,uint256): External calls: - require(bool,string)(collateral.transferFrom(msg.sender,address(this),amt),Could not transfer in collateral tokens) State variables written after the call(s): - _addCollateral(vaultOwner,amt) - vault.collateral = vault.collateral.add(amt)

Apply the check-effects-interactions pattern.

ghost avatar Aug 11 '20 04:08 ghost