ConvexityProtocol icon indicating copy to clipboard operation
ConvexityProtocol copied to clipboard

Published 20 hours ago • verified publisher icon opynfinance

OptionsContract.calculateOTokens(uint256,OptionsContract.Number) (OptionsContract.sol#908-943) performs a multiplication on the result of a division

Open ghost opened this issue 4 years ago • 0 comments

OptionsContract.calculateOTokens(uint256,OptionsContract.Number) performs a multiplication on the result of a division: -numeratorVal = (collateralAmt.mul(collateralToEthPrice)).div(strikeToEthPrice) -numOptions = numeratorVal.mul(10 ** exp).div(denomVal)

Consider ordering multiplication prior division.

ghost avatar Aug 11 '20 04:08 ghost