Convexity-Protocol-Archived icon indicating copy to clipboard operation
Convexity-Protocol-Archived copied to clipboard

Published 20 hours ago • verified publisher icon opynfinance

Options Factory takes in OptionsExchange as an input instead of OptionsExchangeAddress

Open aparnakr opened this issue 5 years ago • 1 comments

aparnakr avatar Feb 22 '20 23:02 aparnakr

the EVM compiler is smart enough to not store contract in bytecode if it is only referenced externally and not deployed from the contract in question. It's preferable to store these things as typed (the way it is currently on master) instead of casting every time you need to call:

https://github.com/opynfinance/Convexity-Protocol/blob/acdaaa36b42e2b68a77a549bc1f1be5eccc94ef7/contracts/OptionsFactory.sol#L18

I recommend closing this issue

epheph avatar Jun 04 '20 21:06 epheph