superset-api-client icon indicating copy to clipboard operation
superset-api-client copied to clipboard

Published 20 hours ago • verified publisher icon opus-42

Support roles as a list property of Dashboards

Open ljpeters opened this issue 2 years ago • 5 comments

The roles input field is revealed after enabling DASHBOARD_RBAC flag. image

The information was already retrieved, but now also stored in the Dashboard during json processing.

ljpeters avatar Aug 12 '22 18:08 ljpeters

I am still working on saving a Dashboard with roles attached. This is not working yet because the save function in base.py is not yet converting the list of Role objects to json.

ljpeters avatar Aug 15 '22 14:08 ljpeters

Hi @ecederstrand or other supersetapiclient developer, I'm done with the changes I needed to store the Roles of a Dashboard. I have applied these changes to my superset setup and they work. I would like to follow through on this PR and merge it.

  • Is the correct target branch set on this PR? I noticed some more changes on develop.
  • Are units test available which I can expand on?
  • I would like to expand documentation in README.md regarding the feature I'm adding, but I would like to do it in a separate PR, is that ok?

ljpeters avatar Aug 22 '22 09:08 ljpeters

Hello @ljpeters ,

Thank you for your contribution. I was on vacations and unable to respond sooner.

  • The correct target branch should be develop
  • On master & develop, there is a skeleton for unit testing the client but it does not yet cover everything.
  • Yes please do it in a separate PR, I will then approve it. At some point we should also release some official documentation on a website.

Thanks again

opus-42 avatar Aug 31 '22 20:08 opus-42

@ljpeters If you merge the latest develop into this branch, then there's now a full test suite you can add test cases to, with lots of examples on how to write tests cases.

ecederstrand avatar Sep 15 '22 08:09 ecederstrand

Is this still in progress?

Ian2012 avatar May 25 '23 21:05 Ian2012