optuna icon indicating copy to clipboard operation
optuna copied to clipboard

Deselect integration tests in Tests CI

Open not522 opened this issue 2 years ago • 2 comments

Motivation

Currently, samplers_tests/test_samplers.py and importance_tests/test_init.py require integration libraries.

Description of the changes

This PR will add an integration marker and test integration samplers / importance-evaluators in the integration tests CI.

not522 avatar Sep 22 '22 03:09 not522

Please merge #3983 first.

not522 avatar Sep 22 '22 06:09 not522

Codecov Report

Merging #4013 (ff9f5b6) into master (8917a51) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4013      +/-   ##
==========================================
+ Coverage   90.10%   90.12%   +0.01%     
==========================================
  Files         162      162              
  Lines       12746    12746              
==========================================
+ Hits        11485    11487       +2     
+ Misses       1261     1259       -2     
Impacted Files Coverage Δ
optuna/integration/botorch.py 98.26% <0.00%> (+0.86%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 22 '22 06:09 codecov-commenter

This pull request has not seen any recent activity.

github-actions[bot] avatar Sep 29 '22 23:09 github-actions[bot]

I updated this PR. We can test basic features using pytest tests -m "not integration" and integrations using pytest tests -m "integration".

not522 avatar Sep 30 '22 05:09 not522

@c-bata Could you review this PR?

HideakiImamura avatar Oct 03 '22 06:10 HideakiImamura

This pull request has not seen any recent activity.

github-actions[bot] avatar Oct 30 '22 23:10 github-actions[bot]

@not522 Any update on this friendly reminder :)

HideakiImamura avatar Nov 01 '22 03:11 HideakiImamura

I updated the PR. Please take another look.

not522 avatar Nov 08 '22 07:11 not522

@not522 Sorry again for the delay and thank you for your huge effort :bow: There seems to be some conflicts due to #4150. Could you resolve it?

c-bata avatar Nov 10 '22 08:11 c-bata

LGTM! I've just enabled auto-merge so that it will be merged after passed all required tests :pray: Thank you for the update.

c-bata avatar Nov 11 '22 09:11 c-bata