optuna icon indicating copy to clipboard operation
optuna copied to clipboard

Unify the arguments of `OptunaSearchCV` and scikit learn's `GridSearchCV`

Open nzw0301 opened this issue 3 years ago • 1 comments

Motivation

In my understanding, OptunaSearchCV is inspired by GridSearchCV's interface to replace grid search in scikit-learn with Optuna's parameter search.

I realised that the current arguments of OptunaSearchCV were not the same as GridSearchCV:

  • the order of arguments differ
  • GridSearchCV uses keyword-only arguments, but OptunaSearchCV does not.

Description

Update the arguments of OptunaSearchCV to follow GridSearchCV for consistency.

Alternatives (optional)

No response

Additional context (optional)

No response

nzw0301 avatar Apr 27 '22 17:04 nzw0301

This issue has not seen any recent activity.

github-actions[bot] avatar May 11 '22 23:05 github-actions[bot]

This issue has not seen any recent activity.

github-actions[bot] avatar Sep 26 '22 23:09 github-actions[bot]

This issue was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely.

github-actions[bot] avatar Oct 23 '22 23:10 github-actions[bot]

#4336 partially addresses this issue

#4336 doesn't include scoring and refit because following sklearn's implementation requires a lot of work, according to the previous attempt. Inconsistent argument ordering with sklearn's searchcv also remains to reduce review cost.

nzw0301 avatar Jan 14 '23 13:01 nzw0301

My attempt for scoring and refit is https://github.com/nzw0301/optuna/tree/prototypo-scoring. Still WIP, but it might not be too hard as I expected.

nzw0301 avatar Jan 14 '23 16:01 nzw0301

This issue has not seen any recent activity.

github-actions[bot] avatar Nov 12 '23 23:11 github-actions[bot]

This issue was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely.

github-actions[bot] avatar Nov 12 '23 23:11 github-actions[bot]