optuna-examples icon indicating copy to clipboard operation
optuna-examples copied to clipboard

Consider introducing type hints and mypy

Open hvy opened this issue 3 years ago • 3 comments

Consider adding type hints to the code and run mypy in the CI (optuna itself has type hints). In addition to the static checking, type hints acts as documentation. The downside is that it will increase maintenance cost.

hvy avatar May 13 '21 04:05 hvy

See also https://github.com/optuna/optuna/issues/2165.

hvy avatar May 18 '21 00:05 hvy

This is a good idea and would bring the examples in line with the optuna/optuna code. This doesn't need to be done all at once, so we welcome contributors to work on adding type hints and mypy compatibility on a example by example basis.

Crissman avatar Jun 01 '21 03:06 Crissman

This issue has not seen any recent activity.

github-actions[bot] avatar Jun 12 '22 23:06 github-actions[bot]

This issue was closed automatically because it had not seen any recent activity. If you want to discuss it, you can reopen it freely.

github-actions[bot] avatar Sep 20 '22 23:09 github-actions[bot]