ActiveLabel.swift icon indicating copy to clipboard operation
ActiveLabel.swift copied to clipboard

Fix value of urlPattern in RegexParser

Open pisces opened this issue 2 years ago • 2 comments

Summary

  • Fixed the problem that other string after url are recognized as url
  • Add a file RegexParserTest.swift

Screenshot

Before After

pisces avatar Mar 30 '22 20:03 pisces

@pisces i just noticed that deep links like my-bundle-id://resource/id aren't picked up by the urlPattern, i tend to use them a lot in customer support context while on device, more reliable "user proofing" than a universal link.

Anyways, i guess i can add a custom handler. That NSRegularExpression escaping in the regexp string for URL makes it so much harder to decompose

rromanchuk avatar Apr 01 '22 21:04 rromanchuk

@rromanchuk I think the existing url pattern doesn't support custom scheme, right?

pisces avatar Apr 02 '22 10:04 pisces