nostalgy-xpi icon indicating copy to clipboard operation
nostalgy-xpi copied to clipboard

Problem with "c" key making Manage emails / Nostalgy++ for TB78 not usable for the moment on TB 78.4.1

Open gbstan opened this issue 4 years ago • 12 comments

Major problem making this wonderful successor to Nostalgy not usable for the moment.

While in the compose window (where you would write the core of the response to an email for example), every time I press the letter "c" the cursor jumps from the compose window to the cc field and starts to type things there. Thunderbird compose window then becomes very slow and unresponsive.

Also copy (CMD+C) doesn't work properly either.

It seems that something linked to the "c" key press is interfering for the moment in ways it shouldn't.

I am on MacOS 10.15.7 and Thunderbird 78.4.1.

gbstan avatar Nov 09 '20 13:11 gbstan

I am also having the "c" key problem described by @gbstan above. I'm running nostalgy-2.2.0 installed from a file, thunderbird 83.0b10 under debian-9 (stretch). In the tools menu, my listing of key-settings is as follows (I'm going to try to include a screen-capture): keys

mvoorhis avatar Nov 09 '20 15:11 mvoorhis

it is not happening on TB 78.4.0 on Win 10. Next, I will test on 78.4.1. Unfortunately, I don't have Linux nor Mac for testing. Klaus

opto avatar Nov 09 '20 16:11 opto

Happening on

Thunderbird 78.4.1 (64 bit) Windows 10 Pro ver. 1909, build 18363.1139

Pam

pchestek avatar Nov 09 '20 17:11 pchestek

Re the 'c' issue (which I also have), is that caused by the ability to type 'cc' to add a cc recipient? If that feature were disabled in the code, I bet we'd have this bug squashed.

BTW, I don't see the ability to change the shortcuts (s, c, g...) any more. But I could live without that for awhile, the previous shortcuts were mnemonic enough for me.

mcswell avatar Nov 09 '20 18:11 mcswell

Shortcuts are set from the Thunderbird "Tools" menu. You should see a "Nostalgy++" entry at the bottom of the tools menu, and in the dialog which appears there is a "Keys" tab. I'm not smart enough to be able to disable the feature and rebuild the XPI myself sadly, or I'd do it and report here.

mvoorhis avatar Nov 09 '20 18:11 mvoorhis

@mvoorhis : ah, thanks for the pointer to the shortcut setting--I guess I was expecting it to be somewhere in the "manage your extensions" page. However, this didn't fix the 'c' problem. I'm thinking this bug is NOT related to the shortcut for "copy to folder", but rather to the "add a cc line" shortcut, which is apparently baked in--it's not listed among the shortcuts. Here's the helpfile ("Nostalgy++ usage directions") for this functionality:

In the Composer

Nostalgy adds some support for keyboard operations to the Composer window.

When typing in an address line (to, cc or bcc), it's possible to change easily the address line to either "To:", "Cc:" or "Bcc:". To do so, you need to be entering a new email address, and simply type "to ", "cc " or "bcc " (with the whitespace, without the quotes). This will open the corresponding address line (cc or bcc), if necessary, and will put the focus into that line.

The issue is that this action seems to be instigated by typing a 'c' character anywhere in the text of an email you're composing, and not just when entering a new email address, as the above would suggest.

P.S. Apologies for the large font, not sure how to turn that off...

mcswell avatar Nov 09 '20 19:11 mcswell

we replace an input handler (onBeforeHandleKeyDown) which now suddenly goes into an infinite loop. Didn't do that in previous versions.

If I remove cc+space and bcc+space, so that we only use esc-c, esc-b, esc-t to switch between to, cc, bcc, all problems are gone. (esc followed by c or b or t within 300ms). I will test more and upload tomorrow, at the moment, it looks good. Klaus

opto avatar Nov 09 '20 19:11 opto

Sounds good--I'd be happy to test it today, if someone can tell me how to install it (other than through the TBird download, since it won't be there until tomorrow).

mcswell avatar Nov 09 '20 19:11 mcswell

thanks. If you send an email to buecher (at) Optosolar (dot) com, I can send a test version with instructions.

opto avatar Nov 09 '20 19:11 opto

I didn't get the test version, but it looks like this auto-updated in TBird today, and it appears to be working fine!!!

mcswell avatar Nov 10 '20 23:11 mcswell

Apropos of my note that I didn't get the test version: I found it in my spam bucket. But it looks like you got at least one other tester, and then published it through TBird's system, and it works. Thank you!

mcswell avatar Nov 11 '20 16:11 mcswell

https://github.com/opto/nostalgy-xpi/releases

Nostalgy++ 2.2.3 with new features

@opto opto released this now

This release has some new features:

Esc-r shows/opens the attachment list of a message. Esc-1 (-2, -3 etc.) displays the first, second ... image attachment. No longer do we need to open an external image viewer to have a preview of Photo/image attachments.

The width of the folderbox in characters can be set in a pref.

The help text in statusbar has been put into a tooltip to give more space for long foldernames.

opto avatar Nov 29 '20 19:11 opto