nostalgy-xpi icon indicating copy to clipboard operation
nostalgy-xpi copied to clipboard

Compose Dialog Settings for CC and BCC have no Effect 102.0.3

Open szmontsaroff opened this issue 1 year ago • 19 comments

Setting "Always show CC/BCC line in compose has no effect on this release of thunderbird.

szmontsaroff avatar Jul 25 '22 04:07 szmontsaroff

found the change in TB, working here already

opto avatar Aug 02 '22 21:08 opto

Does this mean it will be supported in a future release?

szmontsaroff avatar Aug 16 '22 04:08 szmontsaroff

I'm wondering if this might be related to #186 ?

reagle avatar Aug 18 '22 12:08 reagle

I'm having this same issue. @opto When you say "working here already", do we need to do something on our end to get your fix? I'm at 3.6.1 (I'm letting the normal upgrade process in TBird upgrade me when it finds a new version). Thanks.

hkclark avatar Sep 17 '22 13:09 hkclark

I am confused. It is not working in the version from ATN, so maybe I have not yet uploaded it, or maybe the compose dialog has changed again (they changed function names and ids etc. for 102).

opto avatar Oct 02 '22 21:10 opto

I'm not sure where this setting is, but I think it's specific to account settings and I have cc/bcc ticked, but not addresses, and I think this meant always include those headers, but it doesn't in thunderbird 102.3.1 . SCR-20221003-d23 SCR-20221003-d1w

reagle avatar Oct 03 '22 13:10 reagle

please try this: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.3

@reagle: it is not that. This means a setting in the options where you can decide to always show the cc or bcc lines in compose dialog.

opto avatar Oct 04 '22 12:10 opto

@opto Works great for me! You are a hero. Thank you!

hkclark avatar Oct 04 '22 12:10 hkclark

please try this: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.3

@reagle: it is not that. This means a setting in the options where you can decide to always show the cc or bcc lines in compose dialog.

When I turn "show CC" on and I hit reply (all) on an email the caret is in the "TO:" field and not in the body - if I turn it off again the caret is in the body of the email and I can start typing as usual.

Edit: windows 10, 64bit, TB 102.3.0/2

hi5 avatar Oct 07 '22 17:10 hi5

When I turn "show CC" on and I hit reply (all) on an email the caret is in the "TO:" field and not in the body - if I turn it off again the caret is in the body of the email and I can start typing as usual.

Yes, I have noticed that "slight annoyance" as well. But otherwise, it's working great for me.

hkclark avatar Oct 07 '22 17:10 hkclark

Same issue for me with the cursor ending up in the "To" field. Just need to remember to hit tab a few times to get it to the body. Benefits of Nostalgy++ far outweigh this minor inconvenience.

mewalter avatar Oct 10 '22 17:10 mewalter

I'm guessing the focus can be set to the body somehow so it is good to report such things.

hi5 avatar Oct 10 '22 17:10 hi5

yes, thanks for reporting. Can it be fixed? Depends on how to distinguish in the code reply (all) from write, where it would make sense to have cursor in to.

opto avatar Oct 10 '22 20:10 opto

Perhaps: IF subject.hascontent() THEN setfocus.body() the reason being that a reply (all) would always have something in the subject line where as writing a new email in many case won't have one yet (e.g. subject is empty) - of course one can think of cases where the subject line does have content and there is no TO but my guess that would be rare.

hi5 avatar Oct 11 '22 16:10 hi5

please try this. It also revives esc esc to get into the body: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.5

opto avatar Oct 11 '22 19:10 opto

This definitely works when using reply or reply-all. Thanks.

Minor problem is that when using Forward, it also sets focus in the message body. For Forward the expected behavior would be to set focus in the To field. Looks like the approach of using IF subject.hascontent() does neglects the fact that a forwarded message will have a subject but has a blank To field. Sorry,

I am completely ignorant with the code. Is there are "IF to.hascontent()" call? If so, is that the way to go?

mewalter avatar Oct 12 '22 00:10 mewalter

yes and no, because there are the 'crazy' pills showing the addresses. So one would do:? if to empty and subject present, go to to?

opto avatar Oct 12 '22 08:10 opto

you still can go there by esc followed by t

opto avatar Oct 12 '22 08:10 opto

please try this. It also revives esc esc to get into the body: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.5

Works for me, thanks 👍 as does esc-esc, esc-t, esc-c

With regards to forwarding

if to empty and subject present, go to to?

sounds reasonable if possible

hi5 avatar Oct 12 '22 16:10 hi5