nostalgy-xpi icon indicating copy to clipboard operation
nostalgy-xpi copied to clipboard

Bad experience with dark theme

Open ttamttam opened this issue 2 years ago • 13 comments

When (this is my default setting) I select Thunderbird dark theme: — the Search++ button is not visible (maybe there is a way to have it's color inversed, depending on the theme?) — in the key shortcuts table, every second line is unreadable

Many thanks for your work on this essential addon!

ttamttam avatar May 07 '22 17:05 ttamttam

I'd add that under dark mode (Linux) the Prefs window's Rules tab shows white-on-white text for every other (even) row. This can sort of be worked around as the text goes red when the row is selected.

fnxweb avatar Jul 08 '22 11:07 fnxweb

(I think this is a related issue.) When the Nostalgy Preferences are opened the tab labels (Rules, Completion, etc.) are all black on light and readable but when I select another tab the selected tab becomes totally light and the label can't be seen; this continues from that point until the preferences are closed and reopened. It occurs whether the light appearance was set using the Thunderbird light theme or the Mac's light setting (System Preferences/General/Appearance).

zhoravdb avatar Jul 08 '22 17:07 zhoravdb

This problem still exists, making Nostalgy very hard to use with any dark scheme. See example from my screen with standard dark mode from TB. Should be an easy fix, right? Nostalgy status bar ?

DrBoym avatar Aug 09 '22 07:08 DrBoym

In case anyone is interested: The following CSS fixes the status bar issue shown by @DrBoym:

hbox.statusbar[insertbefore="unreadMessageCount"] {
    appearance: none !important;
}

image#me-help {
    filter: invert(1);
}

Simply add it to the chrome/userChrome.css file inside your profile folder and restart Thunderbird.

joreiff avatar Sep 18 '22 09:09 joreiff

Could not. Because there is no chrome directory in my profile folder. And I observe no effect if I create the missing directory and the above file in it.

ttamttam avatar Sep 18 '22 17:09 ttamttam

The directory does not get created automatically, simply create it yourself. And for newer profiles, you might have to enable this feature in the config editor.

joreiff avatar Sep 19 '22 06:09 joreiff

Great! Thank you for the instructions!

ttamttam avatar Sep 26 '22 15:09 ttamttam

Thanks for the simple fix @joreiff! I would note that this also fixes the display for anyone using using the DeepDark theme, including (for the most part) making the Nostalgy settings dialogs readable and usable.

pkiff avatar Sep 27 '22 17:09 pkiff

thanks for that. I have not yet found out how anaddon can find out about dark mode, otherwise Nostalgy could add this.

Klaus

opto avatar Sep 28 '22 12:09 opto

just did dark mode for expressionsearch-ng, so this will be coming in the next week or so.

opto avatar Oct 02 '22 21:10 opto

I am trying but failing to apply the same workaround for the prefs window's tables in dark mode (above); I've added the following to my userChome.css (in my current profile), and seemingly enabled that in the config editor, but it doesn't work. In the debugger, I don't see evidence of userChrome.css being in the list of possible stylesheets (but don't know if I would). I'm wondering if it's something to do with the prefs. window being a popup (it requires normal debugger access to inspect, not the add-on debugger).

#nrules tr:nth-child(even), #nostalgy_key_rows tr:nth-child(even)
{
  background-color: #404040  !important;
}

If I add that in the debugger as a (temporary) custom rule, it does apply OK. I just can't come up with a way of having it work automatically.

fnxweb avatar Nov 10 '22 12:11 fnxweb

just did dark mode for expressionsearch-ng, so this will be coming in the next week or so.

@opto Any news on that topic?

bitwon avatar Feb 28 '23 06:02 bitwon

  1. enabling toolkit.legacyUserProfileCustomizations.stylesheets in the Thunderbird config editor
  2. Adding /chrome/userChrome.css with the specified code inside (as @joreiff suggested) to the folder C:\Users\ USERNAME \AppData\Roaming\Thunderbird\Profiles\ PROFILE FOLDER NAME \ made this work after restarting thunderbird.

Thx all !

Also that would be great to incorporate this feature in the next version of Nostalgy++ as a majority of people are now using dark mode.

ptyx-erd avatar Mar 12 '23 10:03 ptyx-erd