Apply custom keys to an invidual email currently-open/viewed in separate/current window?

[johnnyutahh]

How can I get a save/copy-based Nostalgy++ defined custom key to apply to an email I'm currently viewing in its own, separate (from an email folder-listing) window?

Alain's Nostalgy was able to do this, when I was using it for Thunderbird 68.x, in case that's helpful to know. In a case of a save/move, the window for the current email would close. In case of a copy, said window would stay open. (Assuming I'm remembering everything correctly.)

My current system: Thunderbird v91.5.1, Nostalgy++ 3.1.4, macOS 10.14.6.

[opto]

I brought that back a few days ago. Please test https://github.com/opto/nostalgy-xpi/releases/tag/v3.2.0

Klaus

[johnnyutahh]

Hi Klaus (@opto), this is remarkably useful and appreciated, thank you!

I've only found one problem: the keys for the following actions are working in the folder-email-list view, but not in the individual message window:

Save message and go there
Save message as suggested and go there

In my case, I had to change these key mapping after I installed v3.2.0 (because my original key map was to b, which is used by Thunderbird to "go back to previous message"), and I'm wondering if that change contributed to the problem.

I tried disable-ing and then somehow (?) re-enabling the key... but I can find no re-enable (you probably already know this). Further, after clicking Ok (on the Nostalgy++ popup window) to save the changes, and then re-opening said popup window, the previously-disabled keys are marked as such that they are re-enabled.

Upon which, the Save message... and go there actions still work in the email-folder-list view, but not individual-message window.

Does this feedback help? And is there some workaround I can do (eg: some "reset" I can perform) to get the Save message... and go there actions to work for now?

If not, I'm still thrilled that I have all the other keyboard actions mapped to the individual-message windows now... thanks again!

ps. I sent a small PayPal contribution on Jan 25 (CST). It's not much, but I at least wanted to thank with more than just words. :-)

[johnnyutahh]

In a few mins I plan to try uninstalling-then-reinstalling v3.2.0 to see if I can get the Save message... and go there actions working in individual message window, and then report back the results.

[johnnyutahh]

Uninstalling and reinstalling did not fix anything. Will report here if I discover anything else. (I might try a few other things.)

[johnnyutahh]

Save message... and go there actions for individual message window is still broken.

This after I tried reverting back (details below) to pre-v3.2.0 and changing the Save message... and go there actions to v keys (instead of b keys, to which said actions were original assigned).

I do not plan any further testing for today. I await feedback from Klaus (@opto).

fyi. I do the "reversions" by way of git. I've been git-controlling my Thunderbird-on-macOS profile folder/directory for years. To revert back to a previous version I simply checkout the git version (of the Thunderbird profile dir) that maps to what I want, removing all other changes (git clean -fdx).

[johnnyutahh]

Question: is the following the proper procedure to install an upgraded version Nostalgy++?

I install updated Nostalgy++ revs by executing the Install Add-on From File... menucommand from the settings pulldown in the Add-ons Manager tab within Thunderbird... without un-installing the earlier version of Nostalgy++.

[johnnyutahh]

Klaus (@opto)- if you're interested: I'm happy to test bleeding-edge, non-released udpates. If you have some reasonable confidence in them, to see if stuff can work. I would commit (pun intended) to not running these non-officially-released updates in production, only in a test environment.

You're welcome to email me directly at [email protected] with how to do this. I'm happy to git pull and build my own .xpi install file, if you care to share the procedure.

Details re: my code browsing just now:

I'm sure Klaus knows the following things and much (much) more. I'm simply highlighting this because... well, I happened to dig a little, thought it worth sharing I was digging. :-)

I did a tiny bit of code digging. I do not know if https://github.com/opto/nostalgy-xpi currently contains the "latest" commits. Regardless, commit 42c9817cd495d2b80a1733a5bfb525e7a1f586a4 shows the return false's in the following (from chrome/content/nostalgy.js), and I suspect (although I'm just guessing) it's because "save and go" was deemed not yet ready for release, or something like that:

function NostalgySaveAndGo() {
  if (nostalgy_in_message_window) return false;
  NostalgyCmd('Move messages and go to:', NostalgyMoveToFolderAndGo, true);
  return true;
}

function NostalgySaveAndGoSuggested() {
  if (nostalgy_in_message_window) return false;
  NostalgySuggested(NostalgyMoveToFolderAndGo);
  return true;
}

[johnnyutahh]

Klaus, is it possible to change the behavior of the Save message and Save as suggested actions applied to an individual-message window such that the next message in the folder-list gets opened (instead of simply closing the window)?

Possibly make this a configuration option for the user (to open the next message in a window, or not), if you need to serve the preferences of other users?

[johnnyutahh]

Hi Klaus (@opto), do you have any comments on my notes above?

[opto]

this may not be the right time to look into it. Both folder tree and message tree use a <tree> component, which just now is being replaced by soething else (I think already in 98).

So any changes in that code (including the go problem) will be obsolete in September, as the underlying TB code will disappear and will be replaced with something else (which might be good, better, or not)

[johnnyutahh]

Got it, and this seems to make sense. I will plan to check in on this behavior (much?) later, after the above issues settle.

[opto]

I just 'discovered' this in Nostalgy code: window.SetNextMessageAfterDelete

that is a TB property/preference. Maybe it can be set somewhere in the TB preference system, and maybe it has been changed what the default action does.

A move would be identical to a delete (i.e., the message disappeared from the folder)

[opto]

... you could look at the raw preferences to see whether there is somethig with a similiar name that can be set/unset

[johnnyutahh]

Great, thanks for the tip. I added the following line (via the TB config editor) has been added to prefs.js in the TB profile folder and restarted TB. So far no change in behavior. I'll report here if I see anything different sometime later.

user_pref("window.SetNextMessageAfterDelete", true);

Thanks again Klaus for the follow-up on this, much appreciated!

[opto]

by standard, I think the user prefs are not used anymore. You need to set something somewhere to reenablethat (or maybe it was user css?).