nostalgy-xpi
nostalgy-xpi copied to clipboard
opto
"g" goto does not jump to hidden folders anymore
When using "g" to go to a folder, it brings up the field and selection, but when selected / enter is hit, nothing happens (no folder change).
- 91.2.1 (64-bit) on current Ubuntu / 3.0.4
- 91.3.0 (64-bit) on Win7 / 3.0.4
In Windows at least, I changed the key assignment from G to Control-G and it works fine. I think TB assimilated G for its own . . . --Chris
The weird thing is that the "g" key works... I can select the folder, but when hitting Enter it does not go there, it remains in the current folder.
I still see this, it's a dang nuisance! Refining it: g works if the folder name is visible in the Folder Pane, but not if it's hidden.
I groveled through the whole list of T-bird hotkeys and did not find g used as a shortcut natively, so if it's an issue of competition for the key then it's not an obvious one.
There are some spurious things happening where initialisation comes at the wrong point in time, because TB 91 does not give addons a clear signal (yet) when it is finished initialising. So Nostalgy may initialise and later TB overwrites that.
I just tried G on Win 11, TB 91.4.0 and - unfortunately - it works as expected. That is what makes this (and some other) errors so difficult to debug.
My current idea is to put a 1 second delay before our initialisation. And see whether that helps. I will upload that ca. tonight.
Klaus
Well, just to also leave a positive return : I am also running Windows 10, I have had all versions of TB, up to now 91.4.0 and using Nostalgy++ 3.0.8 and I have never had any problems with the G, neither just "G" nor SHIFT-G, so it seems to me that these problem must be installation specific, either due to other installed TB extensions, or due to the problem that opto is mentionning. Cheers Oliver
I can confirm what Bathsheba said: if the folder is visible (can be on-screen or off-screen) in the folder pane, then "g" works, if it is hidden (no new mails in the unread view, or collapsed) then it (sometimes) works. It's actually not that simple and weirder than that though, even if I un-collapse my entire mail folder tree, I still cant jump to some folders. If I scroll to them to see them on screen and then "g", still no-go. If I click them and then collapse them, go to another folder in the same server, I can get back to it. If I go to another mailserver while leaving them uncollapsed, I can't get there. I can't 100% figure out when it does and does not work, but it seems like there is some list that does not contain all folders so it can't jump there, or it is unwilling to jump to folders that are not "active" in some way (uncollapsed or recently selected. Either way, its weird and used to work fine a few versions ago. I have the same behavior on an Ubuntu box with TB 91.3.1 and a Win 11 laptop with TB 91.4.0 ... extensions are minimal, copy-sent-to-current, automatic-dictionary, nostalgy, and folder pane view switcher (disabled because incompatible) on both systems.
I have no problem to use g or Shift-G to go to any folder I like, collapsed or not. And this works for me as well for local folders as it does for at least second order folder on different IMAP servers I use. If your problem is with IMAP servers, perhaps it is a problem with the way the folder structure is synched. In the TB IMAP server advanced preferences I have checked "taking into account folders which contain sub folders" (wording might be different, I'm translating), and "Allow server to further than these space names" (I have difficulties to translate, it's the last option at the bottom). I do not have checked "show only folders with a subscription". Hope this helps. Cheers.
"Server supports folders that contain sub-folders and messages! ... that is checked. Checking or unchecking the "show only folders with a subscription" does not make a difference. I will try uninstalling and reinstalling the addon on Monday maybe.
@Olifair I set all options as you describe, uninstalled and reinstalled Nostalgy, re-started Tbird, and I still cannot 'g' to a hidden folder.
I must tell you: this bug is real.
@internationils @Bathsheba What Nostalgs++ version are you actually using ? I have tried what internationils is describing and I do not have any problem at all. Even old folders, not used for ages, can be jumped to. Do you see the problem only for G, or also for S and B ?
"s" definitely works. "b" only moves, "G" also does not work. Something else that I noticed is that sometimes I have to click on a folder twice to get it to open... I click on it, and it does not open (even after repeated clicking), I click on another folder and then that folder and I can get to it. Not 100% sure about the version, I think 3.0.11 from github, thats what it says in details. Not sure where to find the official version number of the addon these days. Just re-installed 3.0.11, same problem.
@internationils @Bathsheba What Nostalgs++ version are you actually using ? I have tried what internationils is describing and I do not have any problem at all. Even old folders, not used for ages, can be jumped to. Do you see the problem only for G, or also for S and B ?
I have v3.0.11 . I don't see the problem for S, the message is saved to the hidden folder. B saves the message to the hidden folder but doesn't take me there.
something else weird. After reinstalling 3.0.11 yesterday, TB slowed to a crawl when clicking on an email. Processor usage went up, and it took 30-40 seconds for the mail to come up. Deleting was instantaneous, loading the next one again took that long. Deinstalling nostalgy++ fixed it, reinstalling made the problem show up again. This was only on my Ubuntu box (5.8 kernel), not on the windows box. Any ideas??
I can confirm that being on version 3.0.4 selection of a folder that's not displayed after pressing "G" doesn't jump to the selected folder. I usually have selected to view "unread folders" and "compact view". Only workaround so far is to view "all folders" - then the jump does work.
slow operation might be caused by the discovery of threads/conversations for move destination suggestion. (3.0.11). I am considering to add an option to switch that off, so it can be tested.
Klaus
you could also try G if set to offline. I experience in my TB that there seems to be now much more requests to the server as before. (often, my windows mailserver goes to 50%CPU for long time, and I see in the protocol that TB is iterating all folders to retrieve tags/new emails etc.).
slow operation might be caused by the discovery of threads/conversations for move destination suggestion. (3.0.11). I am considering to add an option to switch that off, so it can be tested.
@opto This would be great, I'd be happy to test. Else could you add a "heavy debug" mode that logs activities in detail (with good resolution timestamps) to see what is causing the high load? Thanks & a happy new year!
Just tried installing 3.0.11 on TB 91.3.1+build1-0ubuntu0.21.10.2 / Kernel 5.13.0-23-generic #23-Ubuntu SMP Fri Nov 26 11:41:15 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux again, and the slowdown still happens. It happens when I click on a mail... I get the "Loading Message..." info at the bottom in the status bar, and then it literally takes a minute (~60 sec) to load and display the message. When I am offline and I switch messages, the selection of a mail essentially hangs TB (no refresh at all in the window) It would be great to be able to see some kind of a debugging log to figure out what is happening.
Testing with logging according to https://wiki.mozilla.org/MailNews:Logging#Linux.2Funix From the console... immediate output:
IPDL protocol error: Handler returned error code!
###!!! [Parent][DispatchAsyncMessage] Error: PClientManager::Msg_ExpectFutureClientSource Processing error: message was deserialized, but the handler returned false (indicating failure)
console.log: "predictFromConversation"
console.log: "findGlodaMsg"
console.log: "before query"
console.log: "tree mousedown"
console.log: "tree mousedown, rowno" 0 1084 169 ({get isTrusted() {
[native code]
}})
IPDL protocol error: Handler returned error code!
###!!! [Parent][DispatchAsyncMessage] Error: PClientManager::Msg_ForgetFutureClientSource Processing error: message was deserialized, but the handler returned false (indicating failure)
...then a little later:
console.log: "coll"
console.log: "helpFindConversation after listener"
console.log: "helpFindConversation after getMessagesCollection"
console.log: "convers" 5
console.log: "msg" 0
console.log: "msg" 1
console.log: "msg" 2
console.log: "msg" 3
console.log: "msg" 4
console.log: "r" ({}) "my_email_net"
console.error: gloda.datastore: "got error in _asyncTrackerListener.handleError(): 19: constraint failed"
...then the selected message finally shows.
The IMAP logging does not show anything useful. Any suggestions on which details from https://wiki.mozilla.org/MailNews:Logging#Main_module_options_within_MailNews I should turn on?
Lets continue the freeze -on-message-select discussion in the other bug opened by someone else: https://github.com/opto/nostalgy-xpi/issues/134
@opto I just tried 3.0.1, 3.0.6, .8, .10 and .11 ... I can't jump to hidden folders in any of these versions. This includes collapsed folders, but if I open the collapsed folders and then re-collapse I can get to all (most?) of them in that sub-tree.
The hanging on selecting mails starts in .10 (see my comment in https://github.com/opto/nostalgy-xpi/issues/134 )
I can confirm that in 91 with the new multiple views, G does not work when the folder is not in the view.
e.g.: set view to favorites only, then G to a folder that is not displayed. -> fails.
I just had a look at the code: Nostalgy tries to find a view where the folder is displayed. But due to the changges with multiple views, it fails. So this is confirmed as a bug. I hve time later in january and will fix this then.
current workaround: select all folders for view.
Klaus
But it's more than that... the "all folders view" must be selected, and also the folders must have been un-collapsed. If I just select the view I can't select some folders, when I un- and then re-collapse them then I can. TB seems to have some concept of "visible & seen" folders under the hood.
there maybe some 'hope' for the G problem: major parts of that code are error prone due to the change of TB to multiple views (like all, recent, favorites) etc.
Alain originally did a major rewrite of selectfolder because that had a major bug (long time ago). Not sure whether that bug still exists, but his rewrite can't work under the new multi mode view.
I am rewriting folderpane view switcher, so i due time, this should also work in Nostalgy++.
Excellent! I miss folderpane view switcher... the latest version from September 2021 only works up to TB 90. If you want help testing either, please let me know. I can test on Win11 and Ubuntu.
well, Alain's workaround is still needed, even if in a modified form: TB's native setFolder is supposed to make the folder visible, but it does not, If its parent is collapsed and invisible, it does not function (
although TB states in ts code: 'This function will also ensure
- that the folder is actually being displayed (that is, that none of its
- ancestors are collapsed.'
That remark in TB's code seems to be outdated. Therefore, no really fast solution is available, but programming by hand.
to be more specific, the TB build in version seems to work if it forces the view to switch to all (if we tell it to do a 'forceselect'.) Is that ok for you? So if you were at favorites, you would be forced into all view
No, unfortunately that does not work. I have a lot of archived folders, and a few (20-30) that mails shows up in, which I see in the "unread" view. What used to happen is that G ended up showing the part of the tree that I jumped to in the unread view, which was great.
As a workaround in the interim, can you force-switch to the "all" view, switch to the folder, and then switch back to the unread view automatically? Or would that force another jump automatically?
Another alternative... if you do need to use the unread view for this, is there a way to collapse / uncollapse folders in such a way that the unread plus the switched to folder are uncollapsed? This is kind of simulating the unread view...
Here's another idea for a workaround: Take a message from the goto folder, mark that message unread, change to the folder, mark the previously toggled message read.