Expression-Search-NG icon indicating copy to clipboard operation
Expression-Search-NG copied to clipboard

Note that you're breaking a piece of the add-ons API for other add-ons

Open jikamens opened this issue 1 year ago • 2 comments

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1871879

This is impacting Send Later: https://github.com/Extended-Thunder/send-later/issues/670

Thanks.

jikamens avatar Feb 24 '24 23:02 jikamens

The reason is the monkeyPatch in ExpressionSearchChrome.jsm:

tabmail.openTab = ...

Since you do not have the current code in this repo, I cannot point to the actual offending code and also cannot contribute :-(

jobisoft avatar Feb 25 '24 11:02 jobisoft

Note that you...

strange wording, at least for non native speakers. Why the "you"? Usually, the item titles are not personalised.

Yes, it is unfortunate that the addon does that, which happens while working around a bug in TB filters, namely https://bugzilla.mozilla.org/show_bug.cgi?id=1885525. That bug actually kills the addon in all its functionality.

opto avatar Mar 17 '24 18:03 opto