klar icon indicating copy to clipboard operation
klar copied to clipboard

klar install from latest source code fails with error "cannot use layer"

Open ashageetha opened this issue 6 years ago • 3 comments

With latest klar source code: go get github.com/optiopay/klar fails with error:

#github.com/optiopay/klar/vendor/github.com/coreos/clair/api/v3/clairpb goworkspace/src/github.com/optiopay/klar/vendor/github.com/coreos/clair/api/v3/clairpb/convert.go:131:67: cannot use layer (type database.AncestryLayer) as type database.Layer in argument to LayerFromDatabaseModel

ashageetha avatar Dec 05 '18 16:12 ashageetha

The tests don't pass anymore either:

# github.com/optiopay/klar/clair [github.com/optiopay/klar/clair.test]
clair/clair_test.go:131:14: undefined: clairpb.Ancestry
FAIL	github.com/optiopay/klar/clair [build failed]

Would be nice to setup a CI system to not merge broken code :)

tsuna avatar Dec 06 '18 22:12 tsuna

@tsuna thanks for the report, might be a problem with vendored version, I'll check it. Totally agree with CI point, we used to use our internal CI but stopped around a year ago. Also https://github.com/optiopay/klar/issues/44

hashmap avatar Dec 07 '18 10:12 hashmap

Can we get this fixed please?

tsuna avatar Dec 11 '18 00:12 tsuna