library icon indicating copy to clipboard operation
library copied to clipboard

Cleaned up Integration code for listVar integration

Open cooperreid-optimizely opened this issue 8 years ago • 2 comments

Cleaned up the integration code to automatically account for Array and String listVars. Removed the reverse for-loop logic.

cooperreid-optimizely avatar Nov 02 '17 21:11 cooperreid-optimizely

Oh okay, I didn't have a great reason to make it a dropdown, so let's just stick to a hardcoded value. As long as we call that out in the docs, I think hardcoded make a lot of sense considering it will automatically included a list of all experiment decisions.

Cooper

On Nov 7, 2017, at 8:17 PM, Spencer Smitherman [email protected] wrote:

@Bigspencey commented on this pull request.

In Integrations/Analytics/Adobe Analytics/List Variable Integration/integration.js:

var redirectInfo = window.optimizely.get('state').getRedirectInfo(); -var list = "list1"; @cooperreid-optimizely what's the rational from moving away from a hard-coded list variable key? The reason I put this in was because customers didn't want to modify the list variable used every time so the integration would genuinely be "one click". Just wanted to confirm there's a reason before I merge in.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

cooperreid-optimizely avatar Nov 08 '17 01:11 cooperreid-optimizely