bitpit icon indicating copy to clipboard operation
bitpit copied to clipboard

patchkernel parallel: update isPartitioned() to return false for 1 MPI rank

Open DMurataj01 opened this issue 2 years ago • 3 comments

DMurataj01 avatar Sep 08 '22 11:09 DMurataj01

This fixes a segfault when attempting to run with one MPI rank

DMurataj01 avatar Sep 08 '22 11:09 DMurataj01

Considering the patch partitioned also when running on a single MPI process was done on purpose. This allows to test MPI code in the very simple case of just one process. I am open to change this, however can you share some details on the segmentation fault you are seeing when running on a single process?

andrea-iob avatar Sep 14 '22 07:09 andrea-iob

Considering the patch partitioned also when running on a single MPI process was done on purpose. This allows to test MPI code in the very simple case of just one process. I am open to change this, however can you share some details on the segmentation fault you are seeing when running on a single process?

Would love to help you but this particular issue was seen by a colleague. I think it makes sense to be able to set n procs to 1 when benchmarking and it follows a serial routine. - @andrea-iob maybe have a debugging override ?

DMurataj01 avatar Sep 23 '22 08:09 DMurataj01

This change has been merged through #365.

andrea-iob avatar Nov 23 '22 10:11 andrea-iob