xlsx-template icon indicating copy to clipboard operation
xlsx-template copied to clipboard
verified publisher icon optilude

Fix table substitution not work in node-red

Open lekhahuynh opened this issue 2 years ago • 3 comments

Reproduce The Error

  1. Install xlsx-template in node-red (3.0.2)
  2. Run substitution table with data is array.
  3. Table not generate in output.

Input: image Output: image

Resolution: After debug source code i see substitution instanceof Array not work in node-red. I and update function check Array by Array.isArray() and it work ok.

image image

lekhahuynh avatar Aug 21 '23 04:08 lekhahuynh

Can I ask you to add test for your scenario?

kant2002 avatar Aug 21 '23 05:08 kant2002

Can I ask you to add test for your scenario?

I know unit test need for any function. But it only change function check array and i see old testing passed. So I think not need to write more test for this case.

Btw, If you think I need add unit test please tell me. I will add test for this scenario. Sorry for my English not good.

lekhahuynh avatar Aug 21 '23 05:08 lekhahuynh

I think we should try setup CI for node-red then. Are you know any examples on opensource projects how to do that, or article that would be helpful.

kant2002 avatar Aug 21 '23 06:08 kant2002