Monocle icon indicating copy to clipboard operation
Monocle copied to clipboard

Prepare next release

Open julien-truffaut opened this issue 2 years ago • 18 comments

Here is the list of changes since 3.1.0: https://github.com/optics-dev/Monocle/compare/v3.1.0...master

We bumped the major version of the scala compiler to 3.2.1. I am not sure what is the impact. I think the next version will be 3.2.0.

julien-truffaut avatar Nov 17 '22 15:11 julien-truffaut

I think the next version will be 3.2.0.

Yes indeed, I already bumped the "base version" in the build.sbt to reflect that.

https://github.com/optics-dev/Monocle/blob/9cfdb174cc55be3d8953243c192c141362cb9f38/build.sbt#L5

https://typelevel.org/sbt-typelevel/faq.html#what-is-a-base-version-anyway

armanbilge avatar Nov 17 '22 15:11 armanbilge

I think before the next release, the PGP_SECRET needs to be updated. I believe it has expired based on the CI logs.

You can generate a new key here: https://typelevel.org/sbt-typelevel/secrets.html#pgp-key

If you use the online key generator, make sure to delete the PGP_PASSPHRASE secret.

armanbilge avatar Nov 26 '22 19:11 armanbilge

Thanks, I will regenerate one.

julien-truffaut avatar Nov 28 '22 08:11 julien-truffaut

@armanbilge scala-native release would be highly appreciated as well.

yuriy-yarosh avatar Dec 31 '22 21:12 yuriy-yarosh

@yuriy-yarosh indeed, fortunately there is a snapshot available while we are waiting :) https://s01.oss.sonatype.org/content/repositories/snapshots/dev/optics/monocle-core_native0.4_3/3.2-dcad42c-SNAPSHOT/

armanbilge avatar Dec 31 '22 21:12 armanbilge

Sorry for the delay. I will try to do it next week.

julien-truffaut avatar Jan 01 '23 03:01 julien-truffaut

@armanbilge I updated PGP_SECRET and deleted PGP_PASSPHRASE. What is the next step? should I create and publish a tag?

julien-truffaut avatar Jan 03 '23 13:01 julien-truffaut

@julien-truffaut great! Yes, you can either create/push a tag locally, or you can just create the release from the GH UI. https://github.com/optics-dev/Monocle/releases/new

armanbilge avatar Jan 03 '23 13:01 armanbilge

Thanks, I didn't know about this UI. I triggered the build, let's cross our fingers :)

julien-truffaut avatar Jan 03 '23 14:01 julien-truffaut

publication failed with this error:

2023-01-03 14:39:25.982Z error [SonatypeClient]     Failed: signature-staging, failureMessage:No public key: Key with id: (48fbfd133fedb341) was not able to be located on <a href="http://pgp.mit.edu:11371/">http://pgp.mit.edu:11371/</a>. Upload your public key and try the operation again.  - (SonatypeClient.scala:385)
2023-01-03 14:39:25.984Z error [Sonatype] [STAGE_FAILURE] Failed to close the repository.  - (Sonatype.scala:440)

julien-truffaut avatar Jan 03 '23 14:01 julien-truffaut

@julien-truffaut did you submit the public key to the key server as explained here? https://typelevel.org/sbt-typelevel/secrets.html#pgp-key

armanbilge avatar Jan 03 '23 14:01 armanbilge

Yes but I must have made a mistake. I regenerated a key and restarted the build and now it works :) Thanks

julien-truffaut avatar Jan 03 '23 15:01 julien-truffaut

Artifacts are live: https://repo1.maven.org/maven2/dev/optics/monocle-core_3/3.2.0/

armanbilge avatar Jan 03 '23 15:01 armanbilge

I will try to write the release notes over the next week or two.

julien-truffaut avatar Jan 03 '23 19:01 julien-truffaut

There's also an "auto-generate release notes" button in the GH UI :)

armanbilge avatar Jan 03 '23 19:01 armanbilge

Yeah but it isn't great

julien-truffaut avatar Jan 03 '23 19:01 julien-truffaut

@armanbilge I updated the release notes. If you have a minute wold you mind reviewing it?

julien-truffaut avatar Jan 04 '23 12:01 julien-truffaut

@julien-truffaut LGTM 👍 thanks!

armanbilge avatar Jan 04 '23 12:01 armanbilge