monorepo icon indicating copy to clipboard operation
monorepo copied to clipboard

move fink, manage, and badge to changeset based deployment

Open samuelstroschein opened this issue 2 years ago • 6 comments

Problem

Fink deploys on every commit to main, which leads to:

  • deployment of unreleased changes yet e.g. the SDK
  • the infamous "don't push on Friday" problem

Proposal

  1. Don't auto-deploy on changes.
  2. Force changesets
  3. Have a CI action that deploys fink when the version increases
  • [ ] fink
  • [ ] manage
  • [ ] badge

cc @janfjohannes (because we discussed this)

samuelstroschein avatar Jan 15 '24 22:01 samuelstroschein

@NiklasBuchfink 1. agree?

  1. I assigned you because @flornkm is gone. If you implement it for Fink, you should be able to re-use the logic for manage and badge too

samuelstroschein avatar Jan 15 '24 22:01 samuelstroschein

Let's do this 👍🏼 I see the benefits and we need better quality this year.

NiklasBuchfink avatar Jan 15 '24 22:01 NiklasBuchfink

@samuelstroschein thanks its a really good idea, render will internally build a docker image for each service that is bumped in version and keep that in the deployment history, so if this works out, this is effectively like a small version of the docker setup i had in mind. i think the next step is to add the changeset workflow into our own ci as the github action runner we use at the moment is very slow, unreliable and noisy on prs. it should not be too hard to do.

janfjohannes avatar Jan 16 '24 11:01 janfjohannes

@janfjohannes i think the next step is to add the changeset workflow into our own ci as the github action runner we use at the moment is very slow, unreliable and noisy on prs. it should not be too hard to do.

Let's evaluate https://rushjs.io/ before we build too much infra for changesets.

  • changesets is unmaintained
  • rush seems to solve many problems all at once
  • rush has baking from Microsoft, TikTok, Big tech (will not go unmaintained)

@janfjohannes should we spare time investigating rush?

samuelstroschein avatar Jan 16 '24 15:01 samuelstroschein

@samuelstroschein sure lets give a try if we can replace nx with rush and get changeset features on top

janfjohannes avatar Jan 16 '24 17:01 janfjohannes

@NiklasBuchfink assigned you as you are already working on version / hash display in fink

NilsJacobsen avatar Apr 09 '24 12:04 NilsJacobsen

duplicate in linear https://linear.app/opral/issue/FINK-5/move-fink-manage-and-badge-to-changeset-based-deployment

samuelstroschein avatar May 21 '24 20:05 samuelstroschein