oppia icon indicating copy to clipboard operation
oppia copied to clipboard

Show all associated topics for skill opportunities

Open sagangwee opened this issue 4 years ago • 5 comments

Because we store the topic name associated with a question suggestion's skill in the change object of a question suggestion object, we need to update the question object change object whenever the topic name changes.

sagangwee avatar Mar 23 '20 22:03 sagangwee

Shouldn't the topic name not be part of this payload? Questions should be connected only to skills, not to topics. (The same skill can belong to more than one topic.)

seanlip avatar Mar 23 '20 22:03 seanlip

Hmm, we may need to re-design the UI to reflect that relationship better.

Currently one question suggestion opportunity is listed for each skill/topic pair, since each opportunity for creating a new question suggestion has a label with the format 'Skill Description / Topic Name'. When a suggestion is submitted, the topic name is also propagated to display during the suggestion review.

So maybe what we want instead is for the opportunity to list all topics associated with the skill? Or maintain the current UI and just omit the topic name in the submitted suggestion?

sagangwee avatar Mar 23 '20 23:03 sagangwee

Yeah, I think listing all topics associated with the skill, or maybe just any one random topic associated with the skill, would be good!

seanlip avatar Mar 23 '20 23:03 seanlip

@sagangwee, Can we close this issue now? If yes then can you please close this issue (and add info about why we are closing this.)

DubeySandeep avatar Mar 29 '20 06:03 DubeySandeep

I'll update the issue to reflect our email discussion. Namely, we want to add the ability to see topics corresponding to the skill opportunities with a text like "Linked to: Fractions" or "Linked to: Fractions + 1 other (see more)".

sagangwee avatar Mar 31 '20 17:03 sagangwee

Actually I'm not sure we need this issue. Originally the idea was to show the topics a skill was linked to like this:

Image

But this seemed to tie to the issue of not wanting to show the topic name in the modal for this PR: https://github.com/oppia/oppia/pull/8353

Looking at the current behaviour on the Contributor Dashboard, I think what we're doing now (showing one topic per skill) is totally fine and I haven't seen any confusion related to this point. So let's close this.

seanlip avatar Sep 24 '22 01:09 seanlip